Enable warnings as errors on Aarch64 in the JIT - #18382
Conversation
Enable `OMR_WARNINGS_AS_ERRORS` on Aarch64 in the JIT and remove `--disable-warnings-as-errors` flag by default on Aarch64 for JCL and OpenJDK Jenkins builds Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
|
@0xdaryl as we discussed earlier today... |
|
@knn-k : any objections to enabling this now? |
knn-k
left a comment
knn-k
left a comment
There was a problem hiding this comment.
No objection.
I built AArch64 OpenJ9 JDK 17 for Linux and macOS locally, and both of them were OK with warnings-as-errors.
|
Build jobs at internal servers finished successfully:
|
|
There are no community build jobs to test this, but internal testing runs fine. |
@0xdaryl are you referring to the UNB testing problems or something else? alinux isn't at UNB, and we can do builds at UNB, the main problem is running testing. |
|
Yes, I was referring to the UNB problems. My mistake about alinux. Konno-san tested this internally on a couple of configurations before we merged this so I don't think we'll see any problems. |
|
I wasn't concerned, I just wanted you to be aware that we can build JVMs at UNB even if we can't test them all concurrently (we can run a limited amount of testing). |
4 participants
"Warnings as errors" is enabled on a component-by-component basis throughout OpenJ9 and OMR. For the JIT, warnings as errors is enabled on every platform in OMR and on x86 and Z in OpenJ9.
This PR enables warnings as errors on Aarch64 in OpenJ9 by:
OMR_WARNINGS_AS_ERRORSflag on ifOMR_ARCH_AARCH64is true--disable-warnings-as-errorsflag which is passed into Aarch64 Mac builds on Jenkins by defaultThis will ensure all builds on Aarch64 compile code with the
-Werrorflag, which will halt compilation if a warning is reported.