Skip to content

Convert jvmtiThread.c to jvmtiThread.cpp - #18459

Merged
gacholio merged 1 commit into
eclipse-openj9:masterfrom
babsingh:main4
Nov 16, 2023
Merged

Convert jvmtiThread.c to jvmtiThread.cpp#18459
gacholio merged 1 commit into
eclipse-openj9:masterfrom
babsingh:main4

Conversation

@babsingh

Copy link
Copy Markdown
Contributor

This will simplify future changes for virtual thread support.

This will simplify future changes for virtual thread support.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh

Copy link
Copy Markdown
Contributor Author

jenkins test sanity plinux,win jdk8,jdk21

@babsingh

Copy link
Copy Markdown
Contributor Author

jenkins test extended.openjdk zlinux jdk21

@babsingh

babsingh commented Nov 16, 2023

Copy link
Copy Markdown
Contributor Author

Failures seen in the builds are unrelated to the PR:

https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_extended.openjdk_s390x_linux_Personal/6/consoleFull

A timeout in GetThreadStateTest is seen, which is seen for the first time. Locally, this failure occurs intermittently. This PR doesn't change any functionality so it is not cause for this failure. I will open an issue to document the intermittent GetThreadStateTest failure.

@babsingh

babsingh commented Nov 16, 2023

Copy link
Copy Markdown
Contributor Author

@gacholio Requesting your review. Taking an approach similar to #18413 w.r.t. the cpp conversion. These changes don't impact functionality; they should only break compilation in the worst-case.

@babsingh
babsingh requested a review from gacholio November 16, 2023 17:59
@gacholio

Copy link
Copy Markdown
Contributor

I personally prefer (type*) to (type *) but I won't insist. What is the reason for this change?

@gacholio

gacholio commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Almost every test suite failed - this is not a sensible situation to be in.

@gacholio

Copy link
Copy Markdown
Contributor

Given the compile successes, this is ready for merge.

@gacholio
gacholio merged commit e95661e into eclipse-openj9:master Nov 16, 2023
@babsingh

babsingh commented Nov 16, 2023

Copy link
Copy Markdown
Contributor Author

I personally prefer (type*) to (type *) but I won't insist.

(type *) is used to be consistent with the existing format in the file.

What is the reason for this change?

To support a follow up change in https://github.com/babsingh/openj9/commits/main3 (WIP).

@tajila

tajila commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

@babsingh you may need to triple deliver to 0.42 and 0.43

@babsingh

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants