Add OPENJCEPLUS_SUPPORT flag in JPP tags - #18544
Merged
Merged
Conversation
Contributor
Author
|
@pshipton Please help to review and advice. |
pshipton
reviewed
Nov 30, 2023
Member
|
Have you signed the Eclipse ECA? The check is failing. |
pshipton
marked this pull request as draft
November 30, 2023 22:39
Member
|
We should explore adding openj9-openjdk-jdk17/closed/src/java.base/share/classes/module-info.java.extra to export openjceplus. |
When building the OpenJCEPlus with Semeru OpenJDK, some java.base packages need to be "exports" to the OpenJCEPlus module. But not all the platforms are supported by OpenJCEPlus. For those not supported platforms, export to OpenJCEPlus module will cause the unknown module error. So, by adding the OPENJCEPLUS_SUPPORT flag in JPP Tags, it will only allow the OpenJCEPlus required java.base packages to be exported on the supported platforms, to avoid the unknown module error. Signed-off-by: Tao Liu <tao.liu@ibm.com>
Member
|
You still need to sign the ECA before this can be accepted, or I could make this simple change instead. |
Contributor
Author
|
@pshipton Just signed the ECA, please help to review. |
taoliult
marked this pull request as ready for review
December 3, 2023 21:44
pshipton
approved these changes
Dec 3, 2023
keithc-ca
approved these changes
Dec 4, 2023
This was referenced Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the OpenJCEPlus with Semeru OpenJDK, some java.base packages need to be "exports" to the OpenJCEPlus module. But not all the platforms are supported by OpenJCEPlus. For those not supported platforms, export to OpenJCEPlus module will cause the unknown module error. So, by adding the OPENJCEPLUS_SUPPORT flag in JPP Tags, it will only allow the OpenJCEPlus required java.base packages to be exported on the supported platforms, to avoid the unknown module error.