Add a flag to return 0 if only one data point has been recorded - #18636
Merged
Conversation
Currently, getProcessCpuLoad() and getSystemCpuLoad() return -1 if only one data point has been recorded. A compatibility flag -XX:[+/-]CpuLoadCompatibility is added to match the behaviour of the RI, which is to return 0. Fixes: eclipse-openj9#13389 Related: eclipse-omr/omr#7189 Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
Contributor
Author
pshipton
approved these changes
Dec 15, 2023
Member
|
@thallium don't forget to open the docs issue |
Member
|
@TobiAjila did you want this in 0.43? |
Contributor
Yes, lets add to 0.43 |
Contributor
Author
|
Docs issue has been open eclipse-openj9/openj9-docs#1232. FYI @pshipton @tajila |
Member
|
@thallium pls cherry pick the commit and create a PR on https://github.com/eclipse-openj9/openj9/tree/v0.43.0-release |
Contributor
Author
|
Just found that a comment wasn't updated correctly and there's a minor formatting issue. I will open a PR to fix them first. |
thallium
added a commit
to thallium/openj9
that referenced
this pull request
Dec 17, 2023
A comment wasn't updated correctly and there's a minor formatting issue in eclipse-openj9#18636 Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, getProcessCpuLoad() and getSystemCpuLoad() return -1 if only one data point has been recorded. A compatibility flag -XX:[+/-]CpuLoadCompatibility is added to match the behaviour of the RI, which is to return 0.
Fixes: #13389
Related: eclipse-omr/omr#7189
Related: #18634