(0.43) Initialize recycled continuations in createContinuation before usage - #18658
Merged
Merged
Conversation
Currently, recycled continuations are reset and initialized in freeContinuation at the end of their use. There are also gaps where the recycled continuation might retain old values and not be properly reset. The above approach leads to corruption and segfaults as seen in the runJavaThread failure reported in eclipse-openj9#16728. To fix the above crash, all continuations (new and recycled) are initialized and reset in createContinuation just before the continuation begins execution. Related: eclipse-openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Dec 19, 2023
Depends on - eclipse-openj9/openj9#18649 - eclipse-openj9/openj9#18657 - eclipse-openj9/openj9#18658 Closes eclipse-openj9/openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
This was referenced Dec 19, 2023
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Dec 19, 2023
Depends on - eclipse-openj9/openj9#18649 - eclipse-openj9/openj9#18657 - eclipse-openj9/openj9#18658 Closes eclipse-openj9/openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Dec 19, 2023
Depends on - eclipse-openj9/openj9#18649 - eclipse-openj9/openj9#18657 - eclipse-openj9/openj9#18658 Closes eclipse-openj9/openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Dec 19, 2023
Depends on - eclipse-openj9/openj9#18649 - eclipse-openj9/openj9#18657 - eclipse-openj9/openj9#18658 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Dec 19, 2023
Depends on - eclipse-openj9/openj9#18649 - eclipse-openj9/openj9#18657 - eclipse-openj9/openj9#18658 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Dec 19, 2023
Depends on - eclipse-openj9/openj9#18649 - eclipse-openj9/openj9#18657 - eclipse-openj9/openj9#18658 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
pshipton
approved these changes
Dec 19, 2023
JasonFengJ9
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Dec 20, 2023
Depends on - eclipse-openj9/openj9#18649 - eclipse-openj9/openj9#18657 - eclipse-openj9/openj9#18658 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
JasonFengJ9
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Dec 20, 2023
Depends on - eclipse-openj9/openj9#18649 - eclipse-openj9/openj9#18657 - eclipse-openj9/openj9#18658 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
JasonFengJ9
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Dec 20, 2023
Depends on - eclipse-openj9/openj9#18649 - eclipse-openj9/openj9#18657 - eclipse-openj9/openj9#18658 Closes eclipse-openj9/openj9#16728 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, recycled continuations are reset and initialized in
freeContinuationat the end of their use. There are also gaps wherethe recycled continuation might retain old values and not be properly
reset.
The above approach leads to corruption and segfaults as seen in
the
runJavaThreadfailure reported in #16728.To fix the above crash, all continuations (new and recycled) are
initialized and reset in
createContinuationjust before thecontinuation begins execution.
Related: #16728