Add a NULL check on threadObject in destroyThreadData - #18688
Merged
Conversation
This will fix the crash in eclipse-openj9#18621. Co-authored-by: Graham Chapman <graham_chapman@ca.ibm.com> Co-authored-by: Babneet Singh <sbabneet@ca.ibm.com> Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
pshipton
approved these changes
Jan 4, 2024
Contributor
Author
|
@pshipton Should I also open PRs to port this fix to 0.42 and 0.43? |
gacholio
approved these changes
Jan 4, 2024
Contributor
|
jenkins test sanity zlinux jdk21 |
Member
Is it a new problem? If it's been a problem forever it can wait for the next release. |
Contributor
Author
This is not a new problem; it can wait for the next release. |
Member
|
Looks like it may have been introduced a little over a year ago. It's a simple low risk change, I'm fine with backporting to 0.42 and 0.43. |
This was referenced Jan 4, 2024
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the crash in #18621.
Co-authored-by: Graham Chapman graham_chapman@ca.ibm.com
Co-authored-by: Babneet Singh sbabneet@ca.ibm.com