Need to define OMRZTPF guard macro to openJ9 UMA build for z/TPF - #18709
Merged
Conversation
Signed-off-by: Jim Johnston <jjohnst@us.ibm.com>
pshipton
approved these changes
Jan 8, 2024
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Jan 8, 2024
Required since eclipse-openj9#18709 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of a Pull Request in the OMR Repository it was realized that J9ZTPF guard macros should not be used in the OMR Repository. Instead, as part of building OMR with OpenJ9 for z/TPF that the OMRZTPF guard macro should be turned on in the OpenJ9 build for z/TPF.
This pull request is simply proposing we define OMRZTPF in the runtime/makelib/targets.mk.ftl for the z/TPF spec only.