Skip to content

AttachAPI updates control file access time for long running applications - #18996

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:attachapiaccessfiles
Mar 2, 2024
Merged

AttachAPI updates control file access time for long running applications#18996
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:attachapiaccessfiles

Conversation

@JasonFengJ9

Copy link
Copy Markdown
Member

AttachAPI updates control file access time for long running applications

Added a system property com.ibm.tools.attach.fileAccessUpdateTime for sleepDays which has a default value 8 (days);
Added a daemon thread to update AttachAPI control files every sleepDays.

close #18720

Signed-off-by: Jason Feng fengj@ca.ibm.com

Comment thread jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/IPC.java Outdated
Comment thread jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/IPC.java Outdated
@JasonFengJ9
JasonFengJ9 force-pushed the attachapiaccessfiles branch 2 times, most recently from f8f2062 to 16d8e9f Compare February 22, 2024 20:20
Comment thread jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/IPC.java Outdated
@JasonFengJ9
JasonFengJ9 force-pushed the attachapiaccessfiles branch 2 times, most recently from fc3e68d to a0152b2 Compare February 23, 2024 04:50
@pshipton

Copy link
Copy Markdown
Member

jenkins line endings check

1 similar comment
@pshipton

Copy link
Copy Markdown
Member

jenkins line endings check

@pshipton

Copy link
Copy Markdown
Member
14:34:52  jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/AttachHandler.java:647: trailing whitespace.
14:34:52  +					break;					

Comment thread jcl/src/java.base/share/classes/com/ibm/oti/vm/VM.java Outdated
Comment thread jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/IPC.java Outdated
Comment thread jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/IPC.java Outdated
Comment thread jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/IPC.java Outdated
Added a system property com.ibm.tools.attach.fileAccessUpdateTime for
sleepDays which has a default value 8 (days);
Added a daemon thread to update AttachAPI control files every sleepDays.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9
JasonFengJ9 force-pushed the attachapiaccessfiles branch from 2e24239 to ca6e9e8 Compare March 1, 2024 19:44
@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins line endings check

@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test sanity aix,alinux,osx,zlinux,win jdk17

@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test sanity win jdk17

@keithc-ca
keithc-ca merged commit 5726a9c into eclipse-openj9:master Mar 2, 2024
@JasonFengJ9
JasonFengJ9 deleted the attachapiaccessfiles branch March 2, 2024 12:22
@pshipton

Copy link
Copy Markdown
Member

A doc issue was never opened for this, @JasonFengJ9 pls open one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attach mechanism implementation needs to prevent deletion of notification files by systemd

3 participants