Skip to content

Exclude testCRaCMXBean for ibm builds - #19000

Merged
pshipton merged 1 commit into
eclipse-openj9:masterfrom
singh264:openj9_issues_18842_for_jdk8_on_vmfarm
Feb 22, 2024
Merged

Exclude testCRaCMXBean for ibm builds#19000
pshipton merged 1 commit into
eclipse-openj9:masterfrom
singh264:openj9_issues_18842_for_jdk8_on_vmfarm

Conversation

@singh264

@singh264 singh264 commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Exclude testCRaCMXBean for ibm builds as vmfarm uses a
fixed TKG version, which does not have the CRAC change.

Issue: #18842
Signed-off-by: Amarpreet Singh Amarpreet.A.Singh@ibm.com

@singh264

singh264 commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

A ppc64 aix jdk8 vmfarm build failed due to #18855 and #18992.

@singh264

singh264 commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@tajila @pshipton requesting your review.

How can I verify if this PR addresses the vmfarm build failure?

@singh264
singh264 marked this pull request as ready for review February 22, 2024 18:19
@pshipton

pshipton commented Feb 22, 2024

Copy link
Copy Markdown
Member

Provided instructions via Slack.

@pshipton

pshipton commented Feb 22, 2024

Copy link
Copy Markdown
Member

jenkins test sanity alinux jdk8

@singh264

singh264 commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

How can I verify if this PR addresses the vmfarm build failure?

Provided instructions via Slack.

I started a vmfarm build.

@pshipton

pshipton commented Feb 22, 2024

Copy link
Copy Markdown
Member

As I mentioned vmfarm is broken atm so the build didn't run. You may be able to restart it when vmfarm is fixed. Also we don't need to talk about IBM internal processes and links in the OpenJ9 open source project.

@pshipton

pshipton commented Feb 22, 2024

Copy link
Copy Markdown
Member

Maybe you should just remove the <impl>ibm</impl> so it doesn't run on IBM Java 8 or z/OS builds. I'm not sure why the <feature>CRAC:required</feature> isn't working for IBM Java 8. @llxia ?

@llxia

llxia commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

yes, we should just remove <impl>ibm</impl>.

I'm not sure why the CRAC:required isn't working for IBM Java 8

It should work on IBM Java8 on Jenkins as expected. However, vmfarm is a different story. It uses a fixed TKG version, which does not have the CRAC change.

@singh264
singh264 force-pushed the openj9_issues_18842_for_jdk8_on_vmfarm branch from b310aa2 to 1c107af Compare February 22, 2024 21:43
Amarpreet Singh Amarpreet Singh
Exclude testCRaCMXBean for ibm builds
6ae44b1 
Exclude testCRaCMXBean for ibm builds as vmfarm uses a
fixed TKG version, which does not have the CRAC change.

Issue: eclipse-openj9#18842
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
@singh264
singh264 force-pushed the openj9_issues_18842_for_jdk8_on_vmfarm branch from 1c107af to 6ae44b1 Compare February 22, 2024 21:51
@singh264

singh264 commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Maybe you should just remove the <impl>ibm</impl> so it doesn't run on IBM Java 8 or z/OS builds.

yes, we should just remove <impl>ibm</impl>.

I removed <impl>ibm</impl>.

@singh264 singh264 changed the title Disable testCRaCMXBean for jdk8 Exclude testCRaCMXBean for ibm builds Feb 22, 2024
@singh264

singh264 commented Feb 22, 2024

Copy link
Copy Markdown
Contributor Author

@pshipton re-requesting your review.

@pshipton
pshipton merged commit 4be0f69 into eclipse-openj9:master Feb 22, 2024
@singh264 singh264 mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pshipton pshipton pshipton approved these changes

Assignees

No one assigned

Labels

comp:test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@singh264 @pshipton @llxia