Update ScopedMemoryAccess_closeScope0 for JDK22 - #19167
Merged
Merged
Conversation
Contributor
Author
|
@gacholio Can you please review these changes? fyi @ChengJin01 @tajila |
babsingh
commented
Mar 18, 2024
Contributor
|
You've added object fields to the J9VMThread, so they must be added to: https://github.com/gacholio/openj9/blob/master/runtime/gc_structs/VMThreadSlotIterator.cpp |
gacholio
reviewed
Mar 18, 2024
babsingh
force-pushed
the
main6
branch
2 times, most recently
from
March 18, 2024 15:13
d0b693e to
7da9809
Compare
In JDK22, the definition has changed to native void closeScope0(MemorySessionImpl session, ScopedAccessError error); The return type has changed from boolean to void, and a second parameter is re-introduced: "ScopedAccessError error". Previously, closeScope0 would be retried until it returned true, which suggested that the scope/session was not found on any thread's stack. The new behaviour sets an asynchronous exception for all threads, which have the scope/session on their stack. The second parameter, error, is the asynchronous exception, which is thrown. Before throwing the error, the thread verifies if the scope/session is still on the stack. If not, the asynchronous exception is cleared and not thrown. Related: eclipse-openj9#13211 (comment) Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
gacholio
approved these changes
Mar 18, 2024
Contributor
|
jenkins test sanity zlinux jdk21 |
Contributor
|
jenkins test sanity,sanity.openjdk alinux jdk22 |
Contributor
|
No actual failures in the JDK21 tests. |
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
May 2, 2024
TestHandshake has been fixed by - eclipse-openj9/openj9#19167 - eclipse-openj9/openj9#19412 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
May 2, 2024
TestHandshake has been fixed by - eclipse-openj9/openj9#19167 - eclipse-openj9/openj9#19412 Related: eclipse-openj9/openj9#13211 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
May 2, 2024
TestHandshake has been fixed by - eclipse-openj9/openj9#19167 - eclipse-openj9/openj9#19412 Related: eclipse-openj9/openj9#13211 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
pshipton
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
May 2, 2024
TestHandshake has been fixed by - eclipse-openj9/openj9#19167 - eclipse-openj9/openj9#19412 Related: eclipse-openj9/openj9#13211 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
May 2, 2024
TestHandshake has been fixed by - eclipse-openj9/openj9#19167 - eclipse-openj9/openj9#19412 Related: eclipse-openj9/openj9#13211 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
pshipton
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
May 3, 2024
TestHandshake has been fixed by - eclipse-openj9/openj9#19167 - eclipse-openj9/openj9#19412 Related: eclipse-openj9/openj9#13211 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JDK22, the definition has changed to
The return type has changed from boolean to void, and a
second parameter is re-introduced:
ScopedAccessError error.Previously,
closeScope0would be retried until it returned true,which suggested that the scope/session was not found on any thread's
stack.
The new behaviour sets an asynchronous exception for all threads,
which have the scope/session on their stack. The second parameter,
error, is the asynchronous exception, which is thrown. Beforethrowing the error, the thread verifies if the scope/session is
still on the stack. If not, the asynchronous exception is cleared
and not thrown.
Related: #13211 (comment)