Fix resetting global lists issue in CRIU reinitializeForRestore - #19426
Merged
Conversation
Member
|
This PR fixed |
amicic
reviewed
May 1, 2024
| /* reset the root of global lists for rebuilding the lists, only in case the gcThreadCount in restore env is more than in original env. */ | ||
| _extensions->unfinalizedObjectLists = NULL; | ||
| _extensions->setOwnableSynchronizerObjectLists(NULL); | ||
| _extensions->setContinuationObjectLists(NULL); |
Contributor
There was a problem hiding this comment.
not related to the problem you are fixing, but seems like we should be reseting ReferenceLists too
Contributor
|
try it differently (what is more in line with how we process these lists in context of Clearing)
|
we need to reset the root of global lists(unfinalizedObjectLists, OwnableSynchronizerObjectLists, ContinuationObjectLists) for rebuilding the lists(array of sublists, the size of array match to gcThreadCount), in case the gcThreadCount in restore env is more than the gcThreadCount in original env. Backup and reset root of global lists before reinitializeForRestore and restore the root of global lists if the lists were not rebuilt during reinitializeForRestore. Signed-off-by: hulin <linhu@ca.ibm.com>
Contributor
|
jenkins test sanity aix,win jdk21 |
Contributor
|
jenkins test sanity.functional xLinux jdk21 |
3 similar comments
Contributor
|
jenkins test sanity.functional xLinux jdk21 |
Contributor
|
jenkins test sanity.functional xLinux jdk21 |
Contributor
|
jenkins test sanity.functional xLinux jdk21 |
Contributor
|
xLinux repetedly failing due to network issues |
amicic
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to reset the root of global lists(unfinalizedObjectLists,
OwnableSynchronizerObjectLists, ContinuationObjectLists) for rebuilding
the lists(array of sublists, the size of array match to gcThreadCount),
in case the gcThreadCount in restore env is more than the gcThreadCount
in original env.
Backup and reset root of global lists before reinitializeForRestore
and restore the root of global lists if the lists were not rebuilt
during reinitializeForRestore.
fix:#19421