Periodically issue malloc_trim at JITServer client - #19506
Merged
Conversation
Contributor
Author
|
Attn @mpirvu. |
mpirvu
reviewed
May 16, 2024
mpirvu
left a comment
mpirvu
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I only have a minor suggestion.
| CalculateOverallCompCPUUtilization(compInfo, crtTime, samplerThread); | ||
| } | ||
| #if defined(J9VM_OPT_JITSERVER) && defined(LINUX) | ||
| static uint64_t lastMallocTrimTime = 0; |
Contributor
There was a problem hiding this comment.
Doesn't this need to be indented more?
Since the next block (line 6736) already has #if defined(J9VM_OPT_JITSERVER) , maybe insert this new code under the same ifdef and just add #if defined(LINUX)
JITServer clients will now periodically call malloc_trim(0), at a configurable interval set by the new option -Xjit:jitserverMallocTrimInterval=<time in ms>. The default is every 30s (30000ms). Setting this interval to 0 will disable the feature entirely. Signed-off-by: Christian Despres <despresc@ibm.com>
mpirvu
approved these changes
May 16, 2024
Contributor
|
jenkins test sanity xlinuxjit,zlinuxjit,alinux64jit jdk17 |
Contributor
|
This commit caused a build break on macOS. See https://openj9-jenkins.osuosl.org/job/Build_JDK11_x86-64_mac_Nightly/819/consoleText for example: |
Contributor
|
It seems there is already a PR to fix it: #19510 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JITServer clients will now periodically call
malloc_trim(0), at a configurable interval set by the new option-Xjit:jitserverMallocTrimInterval=<time in ms>. The default is every 30s (30000ms). Setting the interval to 0 will disable the feature entirely.