Skip to content

Update Thread.interrupted in JVMTI RawMonitorWait - #19844

Merged
hangshao0 merged 1 commit into
eclipse-openj9:masterfrom
babsingh:main8
Jul 17, 2024
Merged

Update Thread.interrupted in JVMTI RawMonitorWait#19844
hangshao0 merged 1 commit into
eclipse-openj9:masterfrom
babsingh:main8

Conversation

@babsingh

@babsingh babsingh commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

JVMTI GetThreadState uses Thread.interrupted to interpret the
thread's state. If a thread is interrupted while waiting for
a monitor in JVMTI RawMonitorWait, then it's Thread.interrupted
field needs to be updated. This allows JVMTI GetThreadState to
return the correct thread state.

Use JVMTI_ERROR_INTERNAL (universal error) for the CRIU error
case.

Fixes: #19498

@babsingh

Copy link
Copy Markdown
Contributor Author

@hangshao0 requesting your review.

Comment thread runtime/jvmti/jvmtiRawMonitor.c
Comment thread runtime/jvmti/jvmtiRawMonitor.c
Comment thread runtime/jvmti/jvmtiRawMonitor.c
@babsingh
babsingh force-pushed the main8 branch 3 times, most recently from 766f04d to bd32edf Compare July 16, 2024 18:02
JVMTI GetThreadState uses Thread.interrupted to interpret the
thread's state. If a thread is interrupted while waiting for
a monitor in JVMTI RawMonitorWait, then it's Thread.interrupted
field needs to be updated. This allows JVMTI GetThreadState to
return the correct thread state.

Use JVMTI_ERROR_INTERNAL (universal error) for the CRIU error
case.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

@fengxue-IS fengxue-IS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChengJin01 ChengJin01 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangshao0

Copy link
Copy Markdown
Contributor

jenkins test sanity.openjdk,extended.openjdk jdk23

@hangshao0

Copy link
Copy Markdown
Contributor

jenkins test sanity.openjdk,extended.openjdk alinux jdk23

@hangshao0

Copy link
Copy Markdown
Contributor

jenkins test sanity,extended amac jdk23

@hangshao0

Copy link
Copy Markdown
Contributor

The functional build failure is caused by adoptium/aqa-tests#5451

@hangshao0

Copy link
Copy Markdown
Contributor

jenkins test sanity,extended amac jdk23

@babsingh

Copy link
Copy Markdown
Contributor Author

Only known/unrelated failures are seen in the two failing PR builds.

@hangshao0
hangshao0 merged commit 53c5b2a into eclipse-openj9:master Jul 17, 2024
@hangshao0

Copy link
Copy Markdown
Contributor

Please create a PR for 0.47 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants