Open XL workaround: lower optimization level for codertinit.cpp - #19899
Merged
Conversation
keithc-ca
reviewed
Jul 22, 2024
Deigue
force-pushed
the
openxl-optimize-wkrd
branch
2 times, most recently
from
October 7, 2024 15:07
98bc3df to
c87102c
Compare
Contributor
Author
|
Rebased, passing with java 21 and java 8, ready to review/merge @keithc-ca |
keithc-ca
changed the title
Deigue
force-pushed
the
openxl-optimize-wkrd
branch
from
January 20, 2025 18:36
c87102c to
d8dd03a
Compare
Deigue
force-pushed
the
openxl-optimize-wkrd
branch
3 times, most recently
from
February 19, 2025 16:24
9e53e33 to
de045e4
Compare
keithc-ca
reviewed
Feb 21, 2025
| if(OMR_OS_ZOS) | ||
| # Workaround a compile problem on z/OS by appending "-O" (to override "-O3"). | ||
| set_property(SOURCE "optimizer/VectorAPIExpansion.cpp" APPEND PROPERTY COMPILE_FLAGS "-O") | ||
| if(CMAKE_C_COMPILER_IS_OPENXL) |
Contributor
There was a problem hiding this comment.
Why doesn't this use OMR_TOOLCONFIG (like in #19880)?
if(OMR_TOOLCONFIG STREQUAL "openxl")
Contributor
Author
There was a problem hiding this comment.
Should be using OMR_TOOLCONFIG, I had forgot the one I was using across PRs post holidays. I made the recommended changes.
Contributor
There was a problem hiding this comment.
I see line 287 was changed, but not this line.
Deigue
force-pushed
the
openxl-optimize-wkrd
branch
from
February 24, 2025 19:33
de045e4 to
682de69
Compare
keithc-ca
requested changes
Feb 24, 2025
| if(OMR_OS_ZOS) | ||
| # Workaround a compile problem on z/OS by appending "-O" (to override "-O3"). | ||
| set_property(SOURCE "optimizer/VectorAPIExpansion.cpp" APPEND PROPERTY COMPILE_FLAGS "-O") | ||
| if(CMAKE_C_COMPILER_IS_OPENXL) |
Contributor
There was a problem hiding this comment.
I see line 287 was changed, but not this line.
Deigue
force-pushed
the
openxl-optimize-wkrd
branch
from
February 25, 2025 16:27
682de69 to
8e0e531
Compare
Open XL compilation causes "expected relocatable expression" error when attempting to compile codertinit.cpp with the O3 optimization level. It was recommended to lower the optimization level for this particular file and an issue has been opened internally to track fixing this issue in context of Open XL. Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@ibm.com>
Deigue
force-pushed
the
openxl-optimize-wkrd
branch
from
February 25, 2025 16:27
8e0e531 to
2628e36
Compare
Contributor
Author
|
Thanks for the feedback, I have addressed the comments/missing changes. |
keithc-ca
approved these changes
Feb 25, 2025
Contributor
|
Jenkins compile aix jdk21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open XL compilation causes "expected relocatable expression" error when attempting to compile codertinit.cpp with the O3 optimization level. It was recommended to lower the optimization level for this particular file and an issue has been opened internally to track fixing this issue in context of Open XL.