[FFI/Test] Test suites intended for the duplicate ffi_type for struct - #19922
Merged
tajila merged 1 commit intoAug 9, 2024
Conversation
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
from
July 26, 2024 04:23
4700c46 to
356fb45
Compare
ChengJin01
added
comp:test
project:panama
Author
|
The new test suites are verified in personal builds on all supported platforms. Reviewer: @tajila, @keithc-ca |
keithc-ca
requested changes
Jul 26, 2024
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
7 times, most recently
from
July 30, 2024 03:26
d180da5 to
9b6226a
Compare
keithc-ca
requested changes
Jul 30, 2024
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
from
July 30, 2024 19:54
9b6226a to
ee37591
Compare
Author
|
@keithc-ca, is there anything else to be addressed in this PR? |
Contributor
|
Yes, I have been reviewing the current state of this; I will share my comments tomorrow. |
keithc-ca
requested changes
Aug 1, 2024
keithc-ca
left a comment
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
I've highlighted a number of unused imports; please remove those from other packages as well.
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
from
August 1, 2024 20:41
ee37591 to
63a6272
Compare
Contributor
|
The description says "avoids the duplicate ffi_type for struct"; please explain what that means. |
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
2 times, most recently
from
August 2, 2024 14:26
2f0ad43 to
2f3fbe8
Compare
Author
As explained in the description at #19714, we will need to optimize the existing code to avoid the creating duplicate ffi_type for the same struct in argument/return type in downcall (already updated the commit description to clarify that). |
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
from
August 2, 2024 19:44
2f3fbe8 to
9ec3dc2
Compare
Author
|
@keithc-ca, I've gone through all related test suites with unused imports & displaced imports fixed. Please help cross-check whether anything else I ignored the latest update. |
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
from
August 2, 2024 21:06
9ec3dc2 to
35d9f5d
Compare
keithc-ca
requested changes
Aug 7, 2024
keithc-ca
left a comment
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
Each of the comments from this round apply to several files other than those explicitly mentioned: please address those issues throughout.
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
from
August 7, 2024 16:04
35d9f5d to
59ae9cb
Compare
keithc-ca
requested changes
Aug 7, 2024
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
from
August 7, 2024 20:13
59ae9cb to
b642c47
Compare
keithc-ca
requested changes
Aug 7, 2024
The changes add new test suites which are used to verify the code that avoids creating the duplicate ffi_type for the same struct for arguments/return type in downcall. Also, these tests must work for the existing FFI specific implementation. Related: eclipse-openj9#19714 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_avoid_duplicating_ffi_type_struct_downcall_2_test_suites
branch
from
August 7, 2024 21:26
b642c47 to
80abde0
Compare
Contributor
|
Jenkins test sanity zlinux jdk17,jdk21,jdk22 |
keithc-ca
approved these changes
Aug 8, 2024
Contributor
|
@tajila Could you review this please? |
tajila
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes add new test suites which are used to verify
the code that avoids creating the duplicate ffi_type for
the same struct for arguments/return type in downcall.
Also, these tests must work for the existing FFI specific
implementation.
Related: #19714
Signed-off-by: ChengJin01 jincheng@ca.ibm.com