Tag jar/keystore files as binary - #20069
Merged
Merged
Conversation
keithc-ca
requested changes
Aug 28, 2024
keithc-ca
left a comment
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
Please update the commit message so the summary line is more like the heading of this pull request (after removing the reference to .war files).
keithc-ca
changed the title
keithc-ca
reviewed
Aug 28, 2024
Signed-off-by: Pasam Soujanya <psoujany@in.ibm.com>
keithc-ca
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes functional compilation issues seen due to improper tagging of jar/war/keystore files on JDK21. Hence tagging these extension files as binary.
Verification : Grinder_CR/22174