Generate checks for all callers in OffHeap when inlining Unsafe.CAS - #20134
Merged
Conversation
When inlining `Unsafe.compareAndSwap` (`compareAndSet`) while using OffHeap ignore the special callers cases which skips generating checks for inlining. The special callers require OffHeap array checks but no low-tag checks, the different treatment of that will be coded into `createUnsafeCASCallDiamond` later on. Signed-off-by: Abdulrahman Alattas <rmnattas@gmail.com>
Contributor
Author
Contributor
|
tested as above ... we can ignore the timeout failure. merging ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inlining
Unsafe.compareAndSwap(compareAndSet) while using OffHeap ignore the special callers cases which skips generating checks for inlining.The special callers require OffHeap array checks but no low-tag checks, the different treatment of that will be coded into
createUnsafeCASCallDiamondlater on.