Skip to content

Generate runtime NULL test for Unsafe.compareAndSwap() - #20163

Merged
zl-wang merged 1 commit into
eclipse-openj9:masterfrom
midronij:unsafe-CAS-nulltest
Sep 16, 2024
Merged

Generate runtime NULL test for Unsafe.compareAndSwap()#20163
zl-wang merged 1 commit into
eclipse-openj9:masterfrom
midronij:unsafe-CAS-nulltest

Conversation

@midronij

Copy link
Copy Markdown
Contributor

Add a NULL test to the sequence of runtime tests performed before calling Unsafe.compareAndSwap() to ensure that when offheap is enabled, we don't try to load dataAddr from a NULL reference.

@midronij

midronij commented Sep 13, 2024

Copy link
Copy Markdown
Contributor Author

@rmnattas @zl-wang Unsafe.CAS() fix is done!

Add a NULL test to the sequence of runtime tests performed before
calling Unsafe.compareAndSwap() to ensure that when offheap is enabled,
we don't try to load dataAddr from a NULL reference.

Signed-off-by: midronij <jackie.midroni@ibm.com>

@zl-wang zl-wang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl-wang

zl-wang commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

jenkins test sanity plinux,xlinux,zlinux jdk8

@zl-wang

zl-wang commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

ignore xlinux infra issue ... merging

@zl-wang
zl-wang merged commit 0985ff3 into eclipse-openj9:master Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants