Prevent Assertion Fail Caused by Incorrect numDeps - #20211
Merged
Conversation
Changed the numDeps parameter so that it is always greater or equal to the number of post conditions added. Avoiding the assertion `TR_ASSERT(newCursor <= _numPostConditions, "Too many dependencies");` being triggered. Signed-off-by: Luke Li <luke.li@ibm.com>
Contributor
Author
|
@hzongaro Can you review this for me? |
Member
|
@BradleyWood, may I ask you to review this pull request? |
BradleyWood
approved these changes
Sep 26, 2024
Member
|
Jenkins test sanity.functional xlinux,xmac,win jdk8,jdk21 |
hzongaro
approved these changes
Sep 26, 2024
Member
|
x86-64 Linux JDK 8 sanity.functional test failure appears to be due to known issue #18599. All other testing was successful. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the numDeps parameter so that it is always greater or equal to the number of post conditions added. Avoiding the assertion
TR_ASSERT(newCursor <= _numPostConditions, "Too many dependencies");being triggered.