Check option TR_DisableIProfilerThread instead of iprofiler thread pr… - #20417
Merged
Conversation
…esence In `TR_Options::feLatePostProcess()` we want to disable the `TR_UseIdleTime` option bit if we don't want to run with an IProfiler thread. Currently this is done by checking the presence of the Iprofiler thread. The problem is that the IProfiler thread is created much later so our query will always return `false`. This commit replaces the check on the IProfiler thread with a check on the `TR_DisableIProfilerThread` option bit. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
dsouzai
approved these changes
Oct 28, 2024
Contributor
|
jenkins test sanity.functional xlinux,plinux jdk21 |
Contributor
Author
|
Tests have passed |
mpirvu
added a commit
to mpirvu/openj9
that referenced
this pull request
Oct 30, 2024
The effect of PR eclipse-openj9#20417 was to enable the TR_UseIdleTime option which was disabled by a code bug. Apparently, this change caused some of the tests to timeout. This commit temporarily disables TR_UseIdleTime until we understand and fix the cause of the timeouts. Fixes: eclipse-openj9#20435 Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
zl-wang
pushed a commit
to zl-wang/openj9
that referenced
this pull request
Nov 11, 2024
The effect of PR eclipse-openj9#20417 was to enable the TR_UseIdleTime option which was disabled by a code bug. Apparently, this change caused some of the tests to timeout. This commit temporarily disables TR_UseIdleTime until we understand and fix the cause of the timeouts. Fixes: eclipse-openj9#20435 Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…esence
In
TR_Options::feLatePostProcess()we want to disable theTR_UseIdleTimeoption bit if we don't want to run with an IProfiler thread. Currently this is done by checking the presence of the Iprofiler thread. The problem is that the IProfiler thread is created much later so our query will always returnfalse.This commit replaces the check on the IProfiler thread with a check on the
TR_DisableIProfilerThreadoption bit.