Cleanup code for MM_IdleGCManager - #20454
Merged
Merged
Conversation
dmitripivkine
commented
Oct 30, 2024
dmitripivkine
commented
Contributor
- using proper types
- code formatting
Contributor
Author
|
fixes #20453 |
amicic
reviewed
Oct 30, 2024
| J9VMRuntimeStateChanged* j9VMState = (J9VMRuntimeStateChanged*)eventData; | ||
| MM_IdleGCManager* idleMgr = (MM_IdleGCManager*)userData; | ||
| J9VMRuntimeStateChanged *j9VMState = (J9VMRuntimeStateChanged *)eventData; | ||
| MM_IdleGCManager* idleMgr = (MM_IdleGCManager *)userData; |
Contributor
There was a problem hiding this comment.
move * in MM_IdleGCManager *idleMgr
amicic
reviewed
Oct 30, 2024
| MM_EnvironmentBase* env = MM_EnvironmentBase::getEnvironment(currentThread->omrVMThread); | ||
| MM_GCExtensions* _extensions = MM_GCExtensions::getExtensions(env); | ||
| MM_EnvironmentBase *env = MM_EnvironmentBase::getEnvironment(currentThread->omrVMThread); | ||
| MM_GCExtensions *_extensions = MM_GCExtensions::getExtensions(env); |
Contributor
There was a problem hiding this comment.
_extensions is declared as a local, so no leading _ is needed
Contributor
There was a problem hiding this comment.
one general comment that we should probably agree on.... often use env and ext as local.
we should either use them in that short form or long form (environment, extension), at least in same method, preferably same file, ideally everywhere
amicic
reviewed
Oct 30, 2024
|
|
||
| /* idle gc manager currently handles only ACTIVE -> IDLE transition*/ | ||
| /* idle gc manager currently handles only ACTIVE -> IDLE transition */ | ||
| if (j9VMState->state == J9VM_RUNTIME_STATE_IDLE) { |
Contributor
There was a problem hiding this comment.
J9VM_RUNTIME_STATE_IDLE on left side
- using proper types - code formatting Signed-off-by: Dmitri Pivkine <Dmitri_Pivkine@ca.ibm.com>
Contributor
Author
|
@amicic Thank you, fixed. |
Contributor
|
Jenkins compile win jdk11 |
amicic
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
