Skip to content

Use debug utility to print TR_YesNoMaybe - #21169

Merged
hzongaro merged 1 commit into
eclipse-openj9:masterfrom
a7ehuo:debug-print-TR_YesNoMaybe
Feb 26, 2025
Merged

Use debug utility to print TR_YesNoMaybe#21169
hzongaro merged 1 commit into
eclipse-openj9:masterfrom
a7ehuo:debug-print-TR_YesNoMaybe

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

Use debug utility to print TR_YesNoMaybe

Closes: #17956

Closes: eclipse-openj9#17956
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo added comp:jit depends:omr Pull request is dependent on a corresponding change in OMR labels Feb 21, 2025
@a7ehuo
a7ehuo requested a review from hzongaro February 21, 2025 14:43
@a7ehuo

a7ehuo commented Feb 21, 2025

Copy link
Copy Markdown
Contributor Author

@hzongaro May I ask you to review this change? Thank you!

This PR depends on eclipse-omr/omr#7669

@a7ehuo

a7ehuo commented Feb 25, 2025

Copy link
Copy Markdown
Contributor Author

The dependency OMR change eclipse-omr/omr#7669 has been promoted to openj9-omr openj9 branch

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro hzongaro self-assigned this Feb 25, 2025
@hzongaro

Copy link
Copy Markdown
Member

Jenkins build sanity.functional all jdk17

@hzongaro

Copy link
Copy Markdown
Member

Jenkins test sanity.functional all jdk17

@hzongaro

Copy link
Copy Markdown
Member

JDK 17 sanity.functional x86-64 Windows test failure was due to known issue #21181.

The change only affects tracing code, and as such, is very safe. Merging.

@hzongaro
hzongaro merged commit 29d8f31 into eclipse-openj9:master Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:jit depends:omr Pull request is dependent on a corresponding change in OMR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define TR::Debug::getName(TR_YesNoMaybe) and replace all traces where a value of TR_YesNoMaybe is printed

2 participants