Fix bug with DAA enablement conditions for off-heap memory - #21561
Merged
r30shah merged 1 commit intoApr 4, 2025
Conversation
Contributor
Author
r30shah
requested changes
Apr 3, 2025
| // We cannot handle arraylets because hardware intrinsics act on contiguous memory | ||
| !comp()->generateArraylets() && !TR::Compiler->om.useHybridArraylets() && | ||
| (!TR::Compiler->om.isOffHeapAllocationEnabled() || comp()->getOption(TR_DisableVectorBCD))) | ||
| (!TR::Compiler->om.isOffHeapAllocationEnabled() || !comp()->getOption(TR_DisableVectorBCD))) |
Contributor
There was a problem hiding this comment.
@VermaSh - Would it be possible to update the condition to make it more clear with the intention here - If offheap is enabled and we do not support VectorBCD then do not do optimization.
Suggested change
| (!TR::Compiler->om.isOffHeapAllocationEnabled() || !comp()->getOption(TR_DisableVectorBCD))) | |
| !(TR::Compiler->om.isOffHeapAllocationEnabled() && comp()->getOption(TR_DisableVectorBCD))) |
Contributor
Author
There was a problem hiding this comment.
I have updated it in my latest update
Contributor
Previously, the non-vectorized DAA path was mistakenly enabled along with the vectorized DAA path for off-heap. Now, only the vectorized DAA path is enabled as intended. Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
VermaSh
force-pushed
the
daa_disable_non-vector_path
branch
from
April 3, 2025 15:42
d176dd9 to
d07dce3
Compare
Contributor
Author
VermaSh
marked this pull request as ready for review
April 3, 2025 17:13
VermaSh
changed the title
Contributor
Author
|
This is ready for review/merge |
r30shah
approved these changes
Apr 3, 2025
Contributor
|
Jenkins test sanity zlinux jdk21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the non-vectorized DAA path was mistakenly enabled along with the vectorized DAA path for off-heap. Now, only the vectorized DAA path is enabled as intended.
Signed-off-by: Shubham Verma shubhamv.sv@gmail.com