Refine and inline MethodHandle.linkTo* methods in ValuePropagation - #21674
Merged
Conversation
Member
Author
|
@jdmpapin requesting review |
jdmpapin
reviewed
Apr 25, 2025
jdmpapin
left a comment
jdmpapin
left a comment
Contributor
There was a problem hiding this comment.
This looks good overall. Just a few minor comments
When ValuePropagation is able to obtain the known object info of the MemberName child of a linkToSpecial, linkToVirtual and linkToStatic call, it is possible to refine the INL call and avoid a more expensive dispatch mechanism. The refined linkTo* INL call then gets inlined during delayed VP transformations. This change also adds a new helper to deal with populating prex arg info and adding the CallInfo to the refined INL call list. Signed-off-by: Nazim Bhuiyan <nubhuiyan@ibm.com>
jdmpapin
approved these changes
Apr 25, 2025
Contributor
|
Jenkins test sanity all jdk21 |
github-project-automation
Bot
moved this from In progress
to Done
in Adopt OpenJDK MethodHandles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ValuePropagation is able to obtain the known object info of the MemberName child of a linkToSpecial, linkToVirtual and linkToStatic call, it is possible to refine the INL call and avoid a more expensive dispatch mechanism. The refined linkTo* INL call then gets inlined during delayed VP transformations.
This change also adds a new static helper to deal with populating prex arg info.