Add JFR NativeLibrary event (Version 2) - #21726
Merged
Merged
Conversation
keithc-ca
self-requested a review
April 25, 2025 13:18
Contributor
|
There currently is no native library support for JFR, so there's nothing to "fix". A better title would be the original, possibly qualified with "take 2" or "version 2" or similar. |
keithc-ca
requested changes
Apr 25, 2025
Contributor
|
I expect similar results for unsupported platforms with this; see #21631 (comment). |
AditiS11
force-pushed
the
nativelib-JFR
branch
3 times, most recently
from
April 28, 2025 13:18
21969ff to
2909df0
Compare
Author
Added the platform check in the testcase. |
AditiS11
force-pushed
the
nativelib-JFR
branch
2 times, most recently
from
April 29, 2025 13:33
443d379 to
24f62f9
Compare
keithc-ca
requested changes
Apr 29, 2025
AditiS11
force-pushed
the
nativelib-JFR
branch
2 times, most recently
from
April 30, 2025 09:23
a03a932 to
6061017
Compare
keithc-ca
requested changes
Apr 30, 2025
Contributor
|
Please resolve the merge conflicts. |
Author
Done |
keithc-ca
requested changes
May 1, 2025
Contributor
|
Please reorder the commit message so the key message is first, e.g.
|
Capture libraryName, base and top addresses for each library.
Author
Done |
Contributor
|
Jenkins test sanity.functional osx,plinux jdk17 |
keithc-ca
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture libraryName, base and top addresses for each library.