Skip to content

Add JFR NativeLibrary event (Version 2) - #21726

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
AditiS11:nativelib-JFR
May 1, 2025
Merged

Add JFR NativeLibrary event (Version 2)#21726
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
AditiS11:nativelib-JFR

Conversation

@AditiS11

Copy link
Copy Markdown

Capture libraryName, base and top addresses for each library.

@keithc-ca
keithc-ca self-requested a review April 25, 2025 13:18
@keithc-ca

Copy link
Copy Markdown
Contributor

There currently is no native library support for JFR, so there's nothing to "fix". A better title would be the original, possibly qualified with "take 2" or "version 2" or similar.

@AditiS11 AditiS11 changed the title Fix "Add JFR NativeLibrary event" Version 2 "Add JFR NativeLibrary event" Apr 25, 2025
Comment thread runtime/vm/JFRConstantPoolTypes.hpp Outdated
@keithc-ca

Copy link
Copy Markdown
Contributor

I expect similar results for unsupported platforms with this; see #21631 (comment).

@AditiS11
AditiS11 force-pushed the nativelib-JFR branch 3 times, most recently from 21969ff to 2909df0 Compare April 28, 2025 13:18
@AditiS11

Copy link
Copy Markdown
Author

I expect similar results for unsupported platforms with this; see #21631 (comment).

Added the platform check in the testcase.

@AditiS11
AditiS11 force-pushed the nativelib-JFR branch 2 times, most recently from 443d379 to 24f62f9 Compare April 29, 2025 13:33
Comment thread test/functional/cmdLineTests/jfr/jfrevents.xml Outdated
Comment thread test/functional/cmdLineTests/jfr/jfrevents.xml Outdated
@AditiS11
AditiS11 force-pushed the nativelib-JFR branch 2 times, most recently from a03a932 to 6061017 Compare April 30, 2025 09:23
Comment thread test/functional/cmdLineTests/jfr/playlist.xml Outdated
@keithc-ca

Copy link
Copy Markdown
Contributor

Please resolve the merge conflicts.

@AditiS11

AditiS11 commented May 1, 2025

Copy link
Copy Markdown
Author

Please resolve the merge conflicts.

Done

Comment thread runtime/vm/JFRConstantPoolTypes.hpp Outdated
@keithc-ca

Copy link
Copy Markdown
Contributor

Please reorder the commit message so the key message is first, e.g.

Add JFR NativeLibrary event (version 2)

Capture libraryName, base and top addresses for each library.
@AditiS11

AditiS11 commented May 1, 2025

Copy link
Copy Markdown
Author

Please reorder the commit message so the key message is first, e.g.

Add JFR NativeLibrary event (version 2)

Done

@AditiS11 AditiS11 changed the title Version 2 "Add JFR NativeLibrary event" Add JFR NativeLibrary event (Version 2) May 1, 2025
@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test sanity.functional osx,plinux jdk17

@keithc-ca
keithc-ca merged commit cf97e25 into eclipse-openj9:master May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants