Anchor the value node before the removal of the call node - #21805
Merged
Conversation
Contributor
Author
|
@hzongaro May I ask you to review this change? Thank you! |
Contributor
|
@r30shah fyi |
hzongaro
reviewed
May 6, 2025
Contributor
|
I agree with Rahil to be conservative. Note that local CSE can common |
Need to anchor the value node before the helper call node is removed. Otherwise, the child value node could be currently anchored under the helper call node. When the helper call node is removed, the value node will be moved down and anchored where the next reference is. It will be a problem if there is a store into this value between the helper call node and the next reference. After the helper call node is removed, the reference will load the updated value instead of the original value. Fixes: eclipse-openj9#21256 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
fix-JProfiling-lowerCalls
branch
from
May 6, 2025 18:52
5cf7d34 to
c365d1a
Compare
Member
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk21 |
Member
|
Jenkins test sanity.functional,sanity.openjdk xmac jdk21 |
Contributor
Author
|
I'm triaging the failed tests. So far, 2 and 4 are known issues. Not sure the other two yet, but the first one crash definitely looks suspicious |
Contributor
Author
|
We can also rule out issue 3 (J9vmTest_3/4 test) since J9vmTest_3 also failed in another PR build test: https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK8_s390x_linux/3014/ |
Member
|
Issue 1 has previously been reported in #21378 (comment) |
Member
|
Test failures are all due to known issues. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to anchor the value node before the helper call node is removed. Otherwise, the child value node could be currently anchored under the helper call node. When the helper call node is removed, the value node will be moved down and anchored where the next reference is. It will be a problem if there is a store into this value between the helper call node and the next reference. After the helper call node is removed, the reference will load the updated value instead of the original value.
Fixes: #21256