Skip to content

Add missing locks for module hashtable access - #22495

Merged
babsingh merged 1 commit into
eclipse-openj9:masterfrom
tajila:vt5
Aug 26, 2025
Merged

Add missing locks for module hashtable access#22495
babsingh merged 1 commit into
eclipse-openj9:masterfrom
tajila:vt5

Conversation

@tajila

@tajila tajila commented Aug 25, 2025 •
edited by pshipton
Loading

Copy link
Copy Markdown
Contributor

Add missing locks for module hashtable access. Also add missing check to scan modularity objects.

Fixes #22264

@tajila

tajila commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

jenkins test sanity plinux jdk25

@tajila

tajila commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

jenkins test sanity alinux64 jdk25

@tajila tajila changed the title Add missing locks for mudle hashtable access Add missing locks for module hashtable access Aug 25, 2025
@tajila

tajila commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

alinux64 https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK25_aarch64_linux/38/
plinux https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK25_ppc64le_linux/41/

@tajila
Add missing locks for module hashtable access
e177593 
Add missing locks for module hashtable access. Also add missing check to
scan modularity objects.

Fixes eclipse-openj9#22264

Signed-off-by: tajila <atobia@ca.ibm.com>
@pshipton

pshipton commented Aug 25, 2025

Copy link
Copy Markdown
Member

Might this also fix #18970?

@dmitripivkine

dmitripivkine commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Might this also fix #18970?

yes indeed

@tajila

tajila commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

@babsingh all tests passed

@tajila
tajila marked this pull request as ready for review August 26, 2025 12:37
@babsingh
babsingh merged commit 6e16eb1 into eclipse-openj9:master Aug 26, 2025
2 checks passed
@dmitripivkine dmitripivkine mentioned this pull request Aug 26, 2025
Closed
@dmitripivkine

dmitripivkine commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Might this also fix #18970?

yes indeed

@pshipton Hm, not so sure now. This fix is applicable for Standard collectors only. #18970 has number of failures with Balanced as well. I am going to inspect Balanced code again for the similar problem (despite it is using very different approach).

@pshipton pshipton mentioned this pull request Aug 26, 2025
Open
This was referenced Aug 27, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@babsingh babsingh babsingh approved these changes
@dmitripivkine dmitripivkine dmitripivkine approved these changes

Assignees

No one assigned

Labels

comp:gc comp:vm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JDK25 OpenJDK java/lang/invoke/MethodHandleProxies/BasicTest crash vmState=0x00000000 isModuleDefined hashTableFind moduleNameHashEqualFn

4 participants

@tajila @pshipton @dmitripivkine @babsingh