Skip to content

(Rework) Print string contents for "this" references - #22554

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
AditiS11:Xtrace-v2
Sep 17, 2025
Merged

(Rework) Print string contents for "this" references#22554
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
AditiS11:Xtrace-v2

Conversation

@AditiS11

@AditiS11 AditiS11 commented Sep 4, 2025

Copy link
Copy Markdown

Address the review comments on: #20933

The changes reflect the feature request #20878.
Print string contents for this references.
Also, print address for string arguments and returns.

@AditiS11

AditiS11 commented Sep 4, 2025

Copy link
Copy Markdown
Author

@keithc-ca,
Could you pls review this.

@keithc-ca
keithc-ca self-requested a review September 4, 2025 18:40
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/mt.tdf Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
@AditiS11
AditiS11 force-pushed the Xtrace-v2 branch 2 times, most recently from fdabcf4 to 48b95ef Compare September 5, 2025 14:51
Comment thread runtime/rastrace/mt.tdf Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/mt.tdf Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/method_trace.c Outdated
Comment thread runtime/rastrace/method_trace.c Outdated

@keithc-ca keithc-ca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash.

Comment thread runtime/rastrace/method_trace.c Outdated
@AditiS11
AditiS11 force-pushed the Xtrace-v2 branch 2 times, most recently from 23e8f60 to f805a56 Compare September 17, 2025 15:54
The changes reflect the feature request eclipse-openj9#20878.

Print string contents for this references.
Also, print address for string arguments and returns.

Closes: eclipse-openj9#20878
Signed-off-by: Nick Kamal <nick.kamal@ibm.com>
@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test sanity.functional zlinux jdk21

@keithc-ca
keithc-ca merged commit 24c8777 into eclipse-openj9:master Sep 17, 2025
5 checks passed
@AditiS11
AditiS11 deleted the Xtrace-v2 branch September 22, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants