Skip to content

Update border frequencies under server inlining - #22561

Merged
vijaysun-omr merged 1 commit into
eclipse-openj9:masterfrom
dsouzai:borderfreq
Sep 10, 2025
Merged

Update border frequencies under server inlining#22561
vijaysun-omr merged 1 commit into
eclipse-openj9:masterfrom
dsouzai:borderfreq

Conversation

@dsouzai

@dsouzai dsouzai commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Update the border frequencies under isServerInlining to 500. This change has been shown to help improve throughput without impacting rampup.

Depends on eclipse-omr/omr#7924

@dsouzai dsouzai added comp:jit depends:omr Pull request is dependent on a corresponding change in OMR labels Sep 5, 2025
@dsouzai

dsouzai commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

@mpirvu @vijaysun-omr

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Looks okay to me. I will await Marius' review as well

Comment thread runtime/compiler/optimizer/J9Inliner.cpp Outdated

@mpirvu mpirvu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Please correct the two typos in "frquences" in the commit message (and PR title) and I can start testing.

@dsouzai dsouzai changed the title Update border frquences under server inlining Update border frequences under server inlining Sep 8, 2025
@vijaysun-omr

Copy link
Copy Markdown
Contributor

That commit only fixed one of the typos :)

"frequences" -> "frequencies" is still needed

@dsouzai dsouzai changed the title Update border frequences under server inlining Update border frequencies under server inlining Sep 8, 2025
This change has been shown to help improve throughput without impacting
rampup.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@vijaysun-omr

Copy link
Copy Markdown
Contributor

jenkins test sanity all jdk21

@dsouzai

dsouzai commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

jenkins test sanity all jdk21 depends eclipse-omr/omr#7924

@vijaysun-omr

Copy link
Copy Markdown
Contributor

jenkins test sanity amac jdk21

@dsouzai

dsouzai commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

jenkins test sanity xmac jdk21

@dsouzai

dsouzai commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

amac nodes are up, but the build node is still offline; seems like xmac nodes are all up so I kicked off testing for that.

@dsouzai

dsouzai commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

jenkins test sanity xmac jdk21 depends eclipse-omr/omr#7924

1 similar comment
@dsouzai

dsouzai commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

jenkins test sanity xmac jdk21 depends eclipse-omr/omr#7924

@dsouzai

dsouzai commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

nvm, looks like xmac build machine are also offline.

@dsouzai

dsouzai commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

@vijaysun-omr The dependent OMR changes have propagated. However, I think the mac nodes are still offline. Because this is common code and all platforms have succeeded including aarch linux and x linux, this should be safe to merge.

@vijaysun-omr

Copy link
Copy Markdown
Contributor

I am going to merge given the last comment and the fact that it is a common code, heuristic change at it's core, rather than adding new function as such, and it passed on other platforms.

@vijaysun-omr
vijaysun-omr merged commit bbd1167 into eclipse-openj9:master Sep 10, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:jit depends:omr Pull request is dependent on a corresponding change in OMR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants