Set register dep to exclude GPR0 for temp2Reg in inlineCompareAndSet - #22633
Merged
Conversation
The temp2Reg is used by `VMnonNullSrcWrtBarCardCheckEvaluator` in some cases in a `stbx` instruction, which can't have GPR0 as the RA argument or it will act upon it as a null value. This causes the an unexpected register spill in the middle of an internal control-flow sequence that might not be fully executed.
Contributor
Author
|
fyi @zl-wang |
Contributor
|
Jenkins test sanity aix,plinux jdk8,jdk21 |
This was referenced Sep 17, 2025
Contributor
|
@AdamBrousseau looks like some infra issue for the failing build? |
Contributor
|
i would consider it as a success: |
Contributor
Agree |
Contributor
|
all tests are successful as indicated above ... merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The temp2Reg is used by
VMnonNullSrcWrtBarCardCheckEvaluatorin some cases in astbxinstruction, which can't have GPR0 as the RA argument or it will act upon it as a null value.This can cause an unexpected register spill in the middle of an internal control-flow sequence that might not be fully executed [1].
The inserted exclusion is sufficiently conditioned under
doWrtBar && doCrdMrk(both true only whengcMode == gc_modron_wrtbar_cardmark_and_oldcheck), similarly conditioned by other callers toVMnonNullSrcWrtBarCardCheckEvaluator, and thestbxinstruction generated byVMnonNullSrcWrtBarCardCheckEvaluatoris conditioned underdoCrdMrk = (gcMode == gc_modron_wrtbar_cardmark_and_oldcheck)Testing: https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/29958/
[1]
Internal RTC 153007