Valhalla support to merge latest OpenJDK contents

[JasonFengJ9]

Valhalla support to merge latest OpenJDK contents

Updated Access APIs according to Valhalla JavaLangAccess;
Added Unsafe.getAndSetReference/getAndSetReferenceAcquire/getAndSetReferenceRelease/notifyStrictStaticAccess stub methods;
Removed Unsafe.uninitializedDefaultValue/newArrayInstance;
Removed @ImplicitlyConstructible;
Removed JVM_IsImplicitlyConstructibleClass/JVM_NewNullRestrictedArray;
Added JVM_CopyOfSpecialArray/JVM_IsAtomicArray/JVM_NewNullRestrictedNonAtomicArray stub methods;
Updated VALUE_TYPES_MAJOR_VERSION;
Replaced ValueClass.newNullRestrictedArray() with ValueClass.newNullRestrictedAtomicArray();
Added @Strict annotations;
Removed CheckedType/NormalCheckedType/NullRestrictedCheckedType, ValueClass isImplicitlyConstructible` references;
Disabled tests expecting implicitly constructible classes as inputs;
Keep the array initialization temporarily;
Updated test build setup.

Related to

• merging latest OpenJDK contents - https://github.com/JasonFengJ9/openj9-openjdk-jdk.valuetypes/tree/mergetmp, (Valhalla) Merge master HEAD into openj9-staging ibmruntimes/openj9-openjdk-jdk.valuetypes#20
• Remove Valhalla workaround for OpenJCEPlus JDK24 references
• Valhalla implementation required for latest OpenJDK/Valhalla updates #22642

A personal build JDKnext_x86-64_linux_valhalla

Co-authored-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com
Signed-off-by: Jason Feng fengj@ca.ibm.com

[JasonFengJ9]

@theresa-m could you have a look?

[theresa-m]

It looks like ValueClass.newNullRestrictedArray has been replaced by ValueClass.newNullRestrictedAtomicArray and ValueClass.newNullRestrictedNonAtomicArray. Instead of removing the tests that rely on newNullRestrictedArray I suggest replacing them all with newNullRestrictedAtomicArray for now. Once newNullRestrictedNonAtomicArray is implemented the tests can be updated to use the correct one.

[theresa-m]

@a7ehuo can you take a look at the jit related changes and tests?

[keithc-ca]

Please open a pull request at https://github.com/ibmruntimes/openj9-openjdk-jdk.valuetypes with the content required for this change.

[theresa-m]

There are more tests that can be enabled. The flattened field tests should mostly work except those that relied on classes with the implicit creation annotation. Something like theresa-m@119430d

[keithc-ca]

I think this looks good, but I'd like to hear from @theresa-m, especially with respect to the test code.

When everyone is happy, this should be rebased to avoid implicit merges.

[theresa-m]

Looks good to me. Thanks for making these changes.

[JasonFengJ9]

@hzongaro could you review the JIT change?

[keithc-ca]

@hzongaro - A friendly reminder that this awaits your review.

could you review the JIT change?

[hzongaro]

Sorry for my delay in reviewing these changes. I'm approving the JIT changes, and I have opened a follow up issue #22769 for someone on the JIT team to go back and add JIT recognition of newly introduced methods for creating non-atomic arrays, etc.

[keithc-ca]

Please rebase to avoid implicit merges.

[JasonFengJ9]

Rebased

[keithc-ca]

Jenkins test sanity amac jdk25,jdknext

[JasonFengJ9]

https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_aarch64_mac_Personal_testList_0/51/consoleFull
https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_aarch64_mac_Personal_testList_1/51/consoleFull

15:35:06  Testing: JFR File name test - approx 5mins
15:35:26  ---TEST RESULTS---
15:35:26  Number of PASSED tests: 11 out of 12
15:35:26  Number of FAILED tests: 1 out of 12
15:35:26  
15:35:26  JFR File name test - approx 5mins
15:35:26  cmdLineTester_jfr_0_FAILED

15:22:36  ---TEST RESULTS---
15:22:36  Number of PASSED tests: 12 out of 13
15:22:36  Number of FAILED tests: 1 out of 13
15:22:36  
15:22:36  ---SUMMARY OF FAILED TESTS---
15:22:36  runWorkload - approx 300 seconds
15:22:36  -----------------------------
15:22:36  
15:22:36  -----------------------------------
15:22:36  cmdLineTester_jfrEvents_0_FAILED

This is #22746