Skip to content

Add missing source folder for jdk.incubator.foreign - #22738

Merged
pshipton merged 1 commit into
eclipse-openj9:masterfrom
keithc-ca:jdk.incubator.foreign
Oct 7, 2025
Merged

Add missing source folder for jdk.incubator.foreign#22738
pshipton merged 1 commit into
eclipse-openj9:masterfrom
keithc-ca:jdk.incubator.foreign

Conversation

@keithc-ca

Copy link
Copy Markdown
Contributor

Noticed while reviewing #22675.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
keithc-ca requested a review from pshipton October 7, 2025 19:24
@pshipton

pshipton commented Oct 7, 2025

Copy link
Copy Markdown
Member

If we haven't had these stubs and classes forever, I'm not sure why we need to add them now. Perhaps it's better to delete them.

@tajila @babsingh any thoughts?

@pshipton

pshipton commented Oct 7, 2025

Copy link
Copy Markdown
Member

Actually never mind, it seems the change only affects Eclipse project setup and not the actual builds.

@pshipton pshipton removed the comp:vm label Oct 7, 2025
@keithc-ca

Copy link
Copy Markdown
Contributor Author

The classes are still used in Java 17, they just weren't included in pConfig JAVA17.

@pshipton
pshipton merged commit 6c7dd1c into eclipse-openj9:master Oct 7, 2025
2 checks passed
@keithc-ca
keithc-ca deleted the jdk.incubator.foreign branch October 7, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants