Implement JIT constant provenance graph - #22813
Conversation
|
@0xdaryl, could you please review? |
|
I've separated the |
0xdaryl
left a comment
There was a problem hiding this comment.
Perhaps this will be apparent when we see you put this graph into action, but will the graph population occur in a single "phase" (not sure that's the right word)? I'm asking mainly because of the tracing code. If the graph is populated in a single "phase" then the tracing output makes sense. But if it is intermixed with other analyses then there isn't anything remarkable about each tracing line to indicate its coming from provenance graph building.
| * The graph essentially consists of directed edges between \em places, where a | ||
| * \em place is one of the following: | ||
| * - a known object (which is what we're ultimately interested in), | ||
| * - an anomymous class, |
See the doxygen for ConstProvenanceGraph in J9ConstProvenanceGraph.hpp. The type is essentially unused for the moment. A follow-up change will populate the graph with edges. After that, the implementation of const refs will include the necessary graph search.
|
The graph won't be populated all at once, no. However, all output for a given call to The trace output from the various overloads of |
|
Jenkins compile all jdk21 Only building rather than running tests since this isn't hooked up yet. |
|
Builds have succeeded |
See the doxygen for
ConstProvenanceGraphin J9ConstProvenanceGraph.hpp.The type is essentially unused for the moment. A follow-up change will populate the graph with edges. After that, the implementation of const refs will include the necessary graph search.