Update DefaultValue Tests - #23032
Merged
Merged
Conversation
theresa-m
self-requested a review
November 27, 2025 15:31
theresa-m
added
comp:vm
project:valhalla
theresa-m
suggested changes
Dec 4, 2025
| @Test(priority=4, invocationCount=2) | ||
| static public void testInitialValueInNullRestrictedLineArray() throws Throwable { | ||
| Object initialStart = makePoint2D.invoke(0, 0); | ||
| Object initialEnd = makePoint2D.invoke(0, 0); |
Contributor
There was a problem hiding this comment.
Use different values for each point. If these objects are flattened then initialStart and initialEnd will not be distinguishable.
| static public void testInitialValueInNullRestrictedTriangleArray() throws Throwable { | ||
| Object initialV1 = makePoint2D.invoke(0, 0); | ||
| Object initialV2 = makePoint2D.invoke(0, 0); | ||
| Object initialLine1 = makeFlattenedLine2D.invoke(initialV1, initialV2); |
Contributor
There was a problem hiding this comment.
Same as the previous comment, please use different values for each point and different points for each line.
Fixes: eclipse-openj9#22916 Update the default value tests to check the initial value for null-restricted arrays.
AditiS11
force-pushed
the
null-restricted
branch
from
December 4, 2025 16:08
64dfc20 to
6dd9093
Compare
theresa-m
approved these changes
Dec 4, 2025
Contributor
|
Jenkins test sanity.functional,extended xlinuxval jdknext |
hangshao0
approved these changes
Dec 5, 2025
github-project-automation
Bot
moved this from TODO: VM
to Reviewer approved
in Valhalla L-World
github-project-automation
Bot
moved this from Reviewer approved
to Done
in Valhalla L-World
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #22916
Update the default value tests to check the
initial value for null-restricted arrays.