Enable CHTable Opts when Xnojit is set to allow AOT - #23096
Conversation
b14f4d5 to
ee6f50d
Compare
ee6f50d to
a9d9d71
Compare
|
If JIT is enabled, typically recompilation and CHTable opts are enabled. If -Xnojit is present (JIT disabled) then AOT compilations are not possible (to double check). AOT loads are permitted though. |
a9d9d71 to
94d2394
Compare
|
To be clearer the behavior that we want is:
|
94d2394 to
d7358fd
Compare
|
Please update the commit message and the description of the PR to match the implementation. |
Fixes issue: eclipse-openj9#17918 Previously, there was an issue that when -Xnojit was set, AOT loads were disabled. This is because -Xnotjit disabled CHTable Ops, which were needed for AOT header validation. This PR enforces that if -Xnojit is specified, then AOT compilations are prohibited but CHTable optimizations are still enabled. Otherwise if recompilations are disabled for any other reason, we also disable CHTable ops. This PR borrows a lot from eclipse-openj9#18543
d7358fd to
45d49d5
Compare
|
jenkins test sanity all jdk25 |
|
openjdk on x86-64 mac failed I don't see how this PR can cause these failures. AOT is never used in these VectorAPI tests because of: |
|
On Windows there is a failure on Again, I don't see how this PR can cause this failure. |
For the record this is a known issue |
Fixes issue:
#17918
Previously, there was an issue that when -Xnojit was set, AOT loads were disabled. This is because -Xnotjit disabled CHTable Ops, which were needed for AOT header validation.
This PR enforces that if -Xnojit is specified, then AOT compilations are prohibited but CHTable optimizations are still enabled. Otherwise if recompilations are disabled for any other reason, we also disable CHTable ops.
This PR borrows a lot from #18543