Skip to content

Prepend VM startup options from java.base/jdk.internal.vm.options - #23508

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:jimageoption
Mar 18, 2026
Merged

Prepend VM startup options from java.base/jdk.internal.vm.options#23508
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:jimageoption

Conversation

@JasonFengJ9

@JasonFengJ9 JasonFengJ9 commented Mar 13, 2026

Copy link
Copy Markdown
Member

Prepend VM startup options from java.base/jdk.internal.vm.options

java.base/jdk.internal.vm.options is a resource file in the jimage file modules created via jlink --add-options <options>;
Insert these VM options into vm->vmArgsArray before processVMArgsFromFirstToLast(vm);
Updated initJImageIntf(), initializeModulesPath() and initializeModulesPathEntry() to be invoked at VM early bootstrap phase when the trace engine hasn't been initialized and the verbose module hasn't been loaded;
Modified createJvmInitArgs() to allow insert VM option entries before current J9VMInitArgs;
Obsoleted a few trace points.

Issue: #23031

Signed-off-by: Jason Feng fengj@ca.ibm.com

Comment thread runtime/bcutil/jimageintf.c Outdated
Comment thread runtime/bcutil/bcutil.c Outdated
Comment thread runtime/bcutil/jimageintf.c Outdated
Comment thread runtime/oti/vmargs_api.h Outdated
Comment thread runtime/oti/vmargs_api.h Outdated
Comment thread runtime/vm/jvminit.c Outdated
Comment thread runtime/vm/jvminit.c Outdated
Comment thread runtime/vm/jvminit.c Outdated
Comment thread runtime/vm/jvminit.c Outdated
Comment thread runtime/vm/jvminit.c Outdated
Comment thread runtime/bcutil/bcutil.c Outdated
Comment thread runtime/oti/vmargs_api.h Outdated
Comment thread runtime/vm/jvminit.c Outdated
Comment thread runtime/oti/vmargs_api.h Outdated
java.base/jdk.internal.vm.options is a resource file in the jimage file
modules created via jlink --add-options <options>;
Insert these VM options into vm->vmArgsArray before
processVMArgsFromFirstToLast(vm);
Updated initJImageIntf(), initializeModulesPath() and
initializeModulesPathEntry() to be invoked at VM early bootstrap phase
when the trace engine hasn't been initialized and the verbose module
hasn't been loaded;
Modified createJvmInitArgs() to allow insert VM option entries before
current J9VMInitArgs;
Obsoleted a few trace points.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test sanity,extended amac jdk25

@JasonFengJ9

JasonFengJ9 commented Mar 18, 2026

Copy link
Copy Markdown
Member Author

https://openj9-jenkins.osuosl.org/job/Test_openjdk25_j9_extended.functional_aarch64_mac_Personal_testList_0/5/consoleFull

10:43:15       [java] [AutoRun] [INFO] Warning: /Users/jenkins/workspace/Test_openjdk25_j9_extended.functional_aarch64_mac_Personal_testList_0/aqa-tests/TKG/../TKG/output_17738427343605/testDDRExtJunit_MonitorsAndDeadlock1_0/DDREXT.J9CORE.DMP is not directory or file!
10:43:15       [java] [AutoRun] [ERROR] No dump file under /Users/jenkins/workspace/Test_openjdk25_j9_extended.functional_aarch64_mac_Personal_testList_0/aqa-tests/TKG/../TKG/output_17738427343605/testDDRExtJunit_MonitorsAndDeadlock1_0/DDREXT.J9CORE.DMP
10:43:15  
10:43:15  BUILD FAILED

10:43:15  testDDRExtJunit_MonitorsAndDeadlock1_0_FAILED

This seems an issue generating the core dump file.
Launched 50x grinder - https://openj9-jenkins.osuosl.org/job/Grinder/5061/ - passed

The core file generation failure doesn't appear related to this PR.

@keithc-ca
keithc-ca merged commit 8f6a2fe into eclipse-openj9:master Mar 18, 2026
6 of 8 checks passed
@JasonFengJ9
JasonFengJ9 deleted the jimageoption branch March 18, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants