Revert "Disable traps on 64-bit Windows" - #23517
Merged
hzongaro merged 1 commit intoMar 17, 2026
Merged
Conversation
Member
|
I think the change looks good, but may I ask you to update the description and commit message to indicate why it's possible to revert this change (referring to pull request #23472 and how that avoids the need to disable traps on Windows)? |
Spencer-Comin
force-pushed
the
enable-windows-traps
branch
from
March 16, 2026 18:11
ad1bc36 to
d2ac550
Compare
This reverts commit b0c55fd. eclipse-openj9#23472 increased the Java stack size on Windows, circumventing the stack overflow error that was seen when trap handlers ran on the Java stack. With that change, the temporary workaround of disabling traps on Windows by default is no longer necessary. Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
force-pushed
the
enable-windows-traps
branch
from
March 16, 2026 18:12
d2ac550 to
1310bbb
Compare
Member
|
Jenkins test sanity.functional,sanity.openjdk xlinux,win,win32 jdk8,jdk21 |
Member
|
JDK 21 x86-64 Linux build failure appears to be due to an infrastructure problem. Rerunning. Jenkins test sanity.functional,sanity.openjdk xlinux jdk21 |
Member
|
Failures running JDK 21 x86-64_windows sanity.functional testing and JDK 8 x86-64_windows sanity.functional testing are due to known issue #22758 (comment) |
Member
|
Testing was successful, except for known issues. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #23123.
#23472 increased the Java stack size on Windows, circumventing the stack overflow error that was seen when trap handlers ran on the Java stack. With that change, the temporary workaround of disabling traps on Windows by default is no longer necessary.