Add a new xtune suboption, xtune:footprint - #23543
Conversation
5ad23a6 to
646969a
Compare
mpirvu
left a comment
There was a problem hiding this comment.
Over-arching comment: I don't think we should mix footprint with aggressiveness levels. The aggressiveness here refers to how aggressive the JIT compiler is in improving throughput.
646969a to
4b1ff86
Compare
mpirvu
left a comment
There was a problem hiding this comment.
Implemented changes look good to me.
Have you thought how to connect J9_RUNTIME_TUNE_FOOTPRINT to the heuristics? Are heuristics going to access vm->runtimeFlags directly? What if we need omr to know about J9_RUNTIME_TUNE_FOOTPRINT? What happens during CRIU restore?
a45639b to
4998d34
Compare
899d366 to
4f1f8a8
Compare
4f1f8a8 to
4c49ad1
Compare
4c49ad1 to
d5bf0ba
Compare
2b80d7b to
30555af
Compare
25eac81 to
d579f42
Compare
|
I was looking into adding CRIU support for this option. However, it seems like none of the options |
|
jenkins compile all jdk26 |
|
jenkins test sanity all jdk26 |
|
Test_openjdk26_j9_sanity.openjdk_x86-64_windows_Personal
https://openj9-jenkins.osuosl.org/job/Test_openjdk26_j9_sanity.openjdk_x86-64_linux_Personal/3/
Test_openjdk26_j9_sanity.openjdk_ppc64_aix_Personal
Test_openjdk26_j9_sanity.functional_ppc64_aix_Personal
All of these appear to be unrelated to the change in this pull request |
d579f42 to
1512975
Compare
|
jenkins test sanity.functional all jdk26 |
|
Test_openjdk26_j9_sanity.functional_x86-64_linux_Personal
test list 0, 2, 3, 5 1,4 Aside from the infra failure, tests 0, 2, 3 and 5 all passed and was incorrectly marked as failed. Tests 1 and 4 did not run. |
|
Test_openjdk26_j9_sanity.functional_x86-64_windows_Personal
0, 2, 3, 5 1, 4 Aside from the infra failure, tests 0, 2, 3 and 5 all passed and was incorrectly marked as failed. Tests 1 and 4 did not run. |
|
Test_openjdk26_j9_sanity.functional_s390x_linux_Personal
0, 1, 2 All three tests ran successfully, and were incorrectly marked as failing |
|
Test_openjdk26_j9_sanity.functional_ppc64le_linux_Personal
These tests did not run |
|
Test_openjdk26_j9_sanity.functional_ppc64_aix_Personal
0, 1, 2 All these tests passed, but were incorrectly marked as failing |
|
Test_openjdk26_j9_sanity.functional_aarch64_mac_Personal
0, 1 All tests ran successfully, and were incorrectly marked as failing |
|
Test_openjdk26_j9_sanity.functional_aarch64_linux_Personal
none of these tests ran |
|
Build_JDK26_x86-64_mac_Personal
build failed due to an issue on the build machine, and not the code |
|
jenkins test sanity.functional xlinux jdk26 |
|
The test on xlinux passed. The other failed due to infra issues. Given this and the fact that the new is protected by the newly created option, this PR is ready to be merged. |
| double scaleFactor = 1; | ||
| bool xtune_footprint = javaVM->runtimeFlags & J9_RUNTIME_TUNE_FOOTPRINT; | ||
| if (xtune_footprint) { | ||
| scaleFactor = 4; | ||
| } else { | ||
| #if defined(J9VM_OPT_CRIU_SUPPORT) | ||
| if (javaVM->internalVMFunctions->isCRaCorCRIUSupportEnabled(javaVM)) { | ||
| scaleFactor = 2; | ||
| } | ||
| #endif | ||
| } | ||
| if (!_extensions->dnssExpectedRatioMaximum._wasSpecified && | ||
| !_extensions->dnssExpectedRatioMinimum._wasSpecified) { | ||
| _extensions->dnssExpectedRatioMaximum._valueSpecified *= scaleFactor; | ||
| _extensions->dnssExpectedRatioMinimum._valueSpecified *= scaleFactor; |
There was a problem hiding this comment.
Please create a follow-up change to indent consistently (with tabs instead of spaces).
Pull request eclipse-openj9#23543 used spaces where it should have used tabs in the file runtime/gc_glue_java/ConfigurationDelegate.hpp. This pull request fixes it. eclipse-openj9#23543
Pull request eclipse-openj9#23543 used spaces where it should have used tabs in the file runtime/gc_glue_java/ConfigurationDelegate.hpp. This pull request fixes it. eclipse-openj9#23543
Pull request eclipse-openj9#23543 used spaces where it should have used tabs in the file runtime/gc_glue_java/ConfigurationDelegate.hpp. This pull request fixes it. eclipse-openj9#23543
Add a new xtune sub option,
xtune:footprintwhich tweaks compiler settings to optimize for footprint reduction.Addresses this issue
#23537