Skip to content

Fix getResolvedMethodsAndMethods for AOT compilations - #23695

Merged
mpirvu merged 1 commit into
eclipse-openj9:masterfrom
dsouzai:fixJitserverGetResolvedMethods
Apr 15, 2026
Merged

Fix getResolvedMethodsAndMethods for AOT compilations#23695
mpirvu merged 1 commit into
eclipse-openj9:masterfrom
dsouzai:fixJitserverGetResolvedMethods

Conversation

@dsouzai

@dsouzai dsouzai commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

getResolvedMethodsAndMethods unconditionally constructed TR_ResolvedJ9JITServerMethod objects. However, for relocatable compilations, it should construct TR_ResolvedRelocatableJ9JITServerMethod objects. This PR fixes this by ensuring that the right resolved method type is created for relocatable compilations.

@dsouzai
Fix getResolvedMethodsAndMethods for AOT compilations
987bd4f 
getResolvedMethodsAndMethods unconditionally constructed
TR_ResolvedJ9JITServerMethod objects. However, for relocatable
compialtions, it should construct
TR_ResolvedRelocatableJ9JITServerMethod objects. This commit fixes this
by ensuring that the right resolved method type is created for
relocatable compilations.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@dsouzai dsouzai added the comp:jitserver Artifacts related to JIT-as-a-Service project label Apr 13, 2026
@dsouzai

dsouzai commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

@mpirvu could you please review?

@mpirvu mpirvu self-assigned this Apr 14, 2026
mpirvu
mpirvu approved these changes Apr 14, 2026
View reviewed changes

@mpirvu mpirvu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu

mpirvu commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk21

@dsouzai

dsouzai commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

zlinux sanity.functional failure is a consequence of #23661; however, I dont' think it's caused by this PR because the method is being compiled at hot, which will not be an AOT compile. Also the error seems to be:

[2026-04-15T00:44:40.766Z] //// 	JITServer: handleServerMessage received an unknown message type: 8

where the 8 is compilationRequest.

I think the zlinuux sanity.openjdk failure is an instance of #19932 but instead of Starvation it's BigInteger, but the symptoms look the same; it's also on a zlinux machine as in 19932. 10x Grinder for the test https://openj9-jenkins.osuosl.org/job/Grinder/5134/.

@mpirvu

mpirvu commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

I agree with both those points above. The assert is a consequence of a recent change that transformed the TR_ASSERT into TR_ASSERT_FATAL to catch bugs. Will treat that one separately.
I will wait for the grinder to complete.

@dsouzai

dsouzai commented Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

Grinder passed 10/10.

@mpirvu

mpirvu commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Merging based on the comments above

@github-project-automation github-project-automation Bot moved this to In progress in JIT as a Service Apr 15, 2026
@mpirvu
mpirvu merged commit aa078f6 into eclipse-openj9:master Apr 15, 2026
13 of 16 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in JIT as a Service Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpirvu mpirvu mpirvu approved these changes

Assignees

@mpirvu mpirvu

Labels

comp:jitserver Artifacts related to JIT-as-a-Service project

Projects

JIT as a Service
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsouzai @mpirvu