Fix return value handling of j9bcv_checkFieldSignature and update documentation - #23756
Merged
keithc-ca merged 1 commit intoApr 16, 2026
Merged
Conversation
konark2010
marked this pull request as draft
April 16, 2026 17:18
konark2010
force-pushed
the
test-illegalLoadableDesciptors
branch
from
April 16, 2026 17:26
01d20f6 to
35aacad
Compare
konark2010
marked this pull request as ready for review
April 16, 2026 17:36
keithc-ca
self-requested a review
April 16, 2026 17:39
keithc-ca
requested changes
Apr 16, 2026
keithc-ca
left a comment
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
Please fix the commit message: The summary line should be no more than 70 characters long. See https://github.com/eclipse-openj9/openj9/blob/master/CONTRIBUTING.md#commit-guidelines.
konark2010
force-pushed
the
test-illegalLoadableDesciptors
branch
from
April 16, 2026 18:23
df095ed to
8ffa1d7
Compare
Contributor
|
Please use parentheses consistently when referring to |
konark2010
force-pushed
the
test-illegalLoadableDesciptors
branch
from
April 16, 2026 18:31
8ffa1d7 to
f39ff91
Compare
Use < 0 to detect errors from j9bcv_checkFieldSignature(). Update documentation to reflect that the function returns 0 on success and negative values on failure. Signed-off-by: Konark Shah <konarkshah2010@gmail.com>
konark2010
force-pushed
the
test-illegalLoadableDesciptors
branch
from
April 16, 2026 18:32
f39ff91 to
5a6ed6a
Compare
Contributor
|
Jenkins test sanity.functional alinuxval,zlinux jdknext |
Contributor
|
Test failures appear unrelated to this change: |
keithc-ca
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.