Fix IsSameObject() to handle value objects - #23817
Merged
Merged
Conversation
theresa-m
added
comp:vm
project:valhalla
theresa-m
reviewed
Apr 24, 2026
| jboolean JNICALL | ||
| isSameObject(JNIEnv *env, jobject ref1, jobject ref2) | ||
| { | ||
| jboolean result = JNI_TRUE; |
Contributor
There was a problem hiding this comment.
You can just call valueTypeCapableAcmp without additional checks for the J9VM_OPT_VALHALLA_VALUE_TYPES case. valueTypeCapableAcmp handles all these cases already.
-Ensure value objects equality check is done using valueTypeCapableAcmp() in IsSameObject(). Signed-off-by: Aditi Srinivas M <Aditi.Srini@ibm.com>
AditiS11
force-pushed
the
TestJNIIsSameObject
branch
from
April 27, 2026 06:19
6a1c537 to
1ae92e0
Compare
theresa-m
approved these changes
Apr 27, 2026
Contributor
|
Jenkins test sanity.functional,extended plinuxval jdknext |
hangshao0
approved these changes
Apr 27, 2026
github-project-automation
Bot
moved this from TODO: VM
to Reviewer approved
in Valhalla L-World
github-project-automation
Bot
moved this from Reviewer approved
to Done
in Valhalla L-World
AditiS11
added a commit
to AditiS11/aqa-tests
that referenced
this pull request
Apr 28, 2026
Enable TestJNIIsSameObject Fixed by: eclipse-openj9/openj9#23817
AditiS11
added a commit
to AditiS11/aqa-tests
that referenced
this pull request
Apr 28, 2026
Enable runtime/valhalla/inlinetypes/TestJNIIsSameObject.java Fixed by: eclipse-openj9/openj9#23817
AditiS11
added a commit
to AditiS11/aqa-tests
that referenced
this pull request
Apr 28, 2026
Enable runtime/valhalla/inlinetypes/TestJNIIsSameObject.java Fixed by: eclipse-openj9/openj9#23817
AditiS11
added a commit
to AditiS11/aqa-tests
that referenced
this pull request
Apr 28, 2026
Enable runtime/valhalla/inlinetypes/TestJNIIsSameObject.java Fixed by: eclipse-openj9/openj9#23817
AditiS11
added a commit
to AditiS11/aqa-tests
that referenced
this pull request
Apr 28, 2026
Enable runtime/valhalla/inlinetypes/TestJNIIsSameObject.java Fixed by: eclipse-openj9/openj9#23817
AditiS11
added a commit
to AditiS11/aqa-tests
that referenced
this pull request
Apr 28, 2026
Enable runtime/valhalla/inlinetypes/TestJNIIsSameObject.java Fixed by: eclipse-openj9/openj9#23817
AditiS11
added a commit
to AditiS11/aqa-tests
that referenced
this pull request
Apr 28, 2026
Enable runtime/valhalla/inlinetypes/TestJNIIsSameObject.java Fixed by: eclipse-openj9/openj9#23817
pshipton
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Apr 28, 2026
Enable runtime/valhalla/inlinetypes/TestJNIIsSameObject.java Fixed by: eclipse-openj9/openj9#23817
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Ensure value objects equality check is done
using valueTypeCapableAcmp() in IsSameObject().
This change is required for
runtime/valhalla/inlinetypes/TestJNIIsSameObject.javaPassing Test: https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/59811/testReport/runtime_valhalla_inlinetypes_TestJNIIsSameObject/