Skip to content

Remove unused j9gc_objaccess_*Split() functions - #23856

Merged
amicic merged 1 commit into
eclipse-openj9:masterfrom
keithc-ca:rm_U64Split
May 5, 2026
Merged

Remove unused j9gc_objaccess_*Split() functions#23856
amicic merged 1 commit into
eclipse-openj9:masterfrom
keithc-ca:rm_U64Split

Conversation

@keithc-ca

@keithc-ca keithc-ca commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This removes these unused functions:

  • j9gc_objaccess_indexableStoreU64Split
  • j9gc_objaccess_mixedObjectCompareAndSwapLongSplit
  • j9gc_objaccess_mixedObjectStoreU64Split
  • j9gc_objaccess_staticCompareAndSwapLongSplit
  • j9gc_objaccess_staticStoreU64Split

Also removes some dead code from FieldRef.java.

@keithc-ca
keithc-ca requested a review from dmitripivkine April 30, 2026 20:09
@amicic

amicic commented May 4, 2026

Copy link
Copy Markdown
Contributor

there a few more of these split methods
from a couple that I checked, also unused

164: j9gc_objaccess_mixedObjectStoreU64Split(J9VMThread *vmThread, J9Object *destObject, UDATA delta, U_32 valueSlot0, U_32 valueSlot1, UDATA isVolatile) 
297: j9gc_objaccess_indexableStoreU64Split(J9VMThread *vmThread, J9IndexableObject *destObject, I_32 index, U_32 valueSlot0, U_32 valueSlot1, UDATA isVolatile) 
382: j9gc_objaccess_staticStoreU64Split(J9VMThread *vmThread, J9Class *clazz, U_64 *destSlot, U_32 valueSlot0, U_32 valueSlot1, UDATA isVolatile) 
504: j9gc_objaccess_mixedObjectCompareAndSwapLongSplit(J9VMThread *vmThread, J9Object *destObject, UDATA offset, U_32 compareValueSlot0, U_32 compareValueSlot1, U_32 swapValueSlot0, U_32 swapValueSlot1) 
533: j9gc_objaccess_staticCompareAndSwapLongSplit(J9VMThread *vmThread, J9Class *destClass, U_64 *destAddress, U_32 compareValueSlot0, U_32 compareValueSlot1, U_32 swapValueSlot0, U_32 swapValueSlot1)

@amicic amicic added the comp:gc label May 4, 2026
@keithc-ca

keithc-ca commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Sure, I'll remove other unused "Split" functions - I only noticed the one mentioned in FieldRef.java.

@keithc-ca
keithc-ca marked this pull request as draft May 4, 2026 20:21
@keithc-ca
Remove unused j9gc_objaccess_*Split() functions
8348f4e 
This removes these unused functions:
* j9gc_objaccess_indexableStoreU64Split
* j9gc_objaccess_mixedObjectCompareAndSwapLongSplit
* j9gc_objaccess_mixedObjectStoreU64Split
* j9gc_objaccess_staticCompareAndSwapLongSplit
* j9gc_objaccess_staticStoreU64Split

Also removes some dead code from FieldRef.java.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
keithc-ca marked this pull request as ready for review May 4, 2026 21:48
@keithc-ca keithc-ca changed the title Remove unused j9gc_objaccess_mixedObjectStoreU64Split() function Remove unused j9gc_objaccess_*Split() functions May 4, 2026
@keithc-ca
keithc-ca requested review from amicic and removed request for dmitripivkine May 4, 2026 21:49
@keithc-ca

keithc-ca commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

a few more of these split methods

Those other unused functions are removed in 8348f4e; also rebased.

@keithc-ca keithc-ca changed the title Remove unused j9gc_objaccess_*Split() functions Remove unused j9gc_objaccess_*Split() functions May 4, 2026
@amicic

amicic commented May 5, 2026

Copy link
Copy Markdown
Contributor

jenkins compile amac jdk21
jenkins compile win32 jdk8

@amicic

amicic commented May 5, 2026

Copy link
Copy Markdown
Contributor

jenkins compile win32 jdk8

@amicic
amicic merged commit 61c9de7 into eclipse-openj9:master May 5, 2026
6 checks passed
@keithc-ca
keithc-ca deleted the rm_U64Split branch May 5, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amicic amicic amicic approved these changes

Assignees

No one assigned

Labels

comp:gc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keithc-ca @amicic