Skip to content

graphql: add nil check in Transaction.Type() method - #33184

Merged
rjl493456442 merged 1 commit into
ethereum:masterfrom
oooLowNeoNooo:fix/transaction-type-nil-check
Nov 14, 2025
Merged

graphql: add nil check in Transaction.Type() method#33184
rjl493456442 merged 1 commit into
ethereum:masterfrom
oooLowNeoNooo:fix/transaction-type-nil-check

Conversation

@oooLowNeoNooo

Copy link
Copy Markdown
Contributor

Add nil check before calling tx.Type() to prevent panic when transaction is not found.

Add nil check before calling tx.Type() to prevent panic when transaction
is not found. This matches the defensive pattern used in other Transaction
resolver methods.
@oooLowNeoNooo
oooLowNeoNooo requested a review from s1na as a code owner November 14, 2025 07:04
@rjl493456442 rjl493456442 changed the title fix(graphql): add nil check in Transaction.Type() method graphql: add nil check in Transaction.Type() method Nov 14, 2025
@rjl493456442 rjl493456442 added this to the 1.16.8 milestone Nov 14, 2025
@rjl493456442
rjl493456442 merged commit aa36bcd into ethereum:master Nov 14, 2025
5 of 7 checks passed
atkinsonholly pushed a commit to atkinsonholly/ephemery-geth that referenced this pull request Nov 24, 2025
Add nil check before calling tx.Type() to prevent panic when transaction
is not found.
prestoalvarez pushed a commit to prestoalvarez/go-ethereum that referenced this pull request Nov 27, 2025
Add nil check before calling tx.Type() to prevent panic when transaction
is not found.
fjl pushed a commit to lightclient/go-ethereum that referenced this pull request Nov 28, 2025
Add nil check before calling tx.Type() to prevent panic when transaction
is not found.
weiihann pushed a commit to weiihann/go-ethereum that referenced this pull request Jan 14, 2026
Add nil check before calling tx.Type() to prevent panic when transaction
is not found.
gballet pushed a commit to BZO95/go-ethereum that referenced this pull request May 21, 2026
Add nil check before calling tx.Type() to prevent panic when transaction
is not found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants