Skip to content

core/vm: Switch to branchless normalization and extend EXCHANGE - #33869

Merged
MariusVanDerWijden merged 6 commits into
ethereum:masterfrom
jrhea:eip-8024-branchless
Mar 4, 2026
Merged

core/vm: Switch to branchless normalization and extend EXCHANGE#33869
MariusVanDerWijden merged 6 commits into
ethereum:masterfrom
jrhea:eip-8024-branchless

Conversation

@jrhea

@jrhea jrhea commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

For bal-devnet-3 we need to update the EIP-8024 implementation to the latest spec changes: ethereum/EIPs#11306

Note: I deleted tests not specified in the EIP bc maintaining them through EIP changes is too error prone.

@jrhea
jrhea force-pushed the eip-8024-branchless branch from 8109f69 to b1b6c46 Compare February 18, 2026 23:09
@jrhea
jrhea marked this pull request as ready for review February 24, 2026 14:09
@jrhea
jrhea requested a review from rjl493456442 as a code owner February 24, 2026 14:09
Comment thread core/vm/instructions.go
@jwasinger jwasinger mentioned this pull request Mar 2, 2026
Comment thread core/vm/instructions.go Outdated
Comment thread core/vm/instructions.go Outdated
@MariusVanDerWijden

Copy link
Copy Markdown
Member

Holy moly, yeah thats some f'd up shit. Maybe we can also link the EIP in the comments, then it seems good to me

Comment thread core/vm/instructions.go
Comment thread core/vm/instructions.go
@jrhea

jrhea commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

Holy moly, yeah thats some f'd up shit. Maybe we can also link the EIP in the comments, then it seems good to me

okay, i added a link to the eip in both decode functions

@jrhea jrhea added this to the 1.17.2 milestone Mar 4, 2026
@MariusVanDerWijden
MariusVanDerWijden merged commit 814edc5 into ethereum:master Mar 4, 2026
10 of 13 checks passed
@jrhea
jrhea deleted the eip-8024-branchless branch August 11, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants