consensus, core, internal, miner: remove FinalizeAndAssemble - #34726
Merged
Conversation
rjl493456442
requested review from
MariusVanDerWijden,
fjl,
lightclient and
s1na
as code owners
April 15, 2026 07:40
rjl493456442
force-pushed
the
block-creation
branch
from
April 16, 2026 03:49
6478572 to
3d88e9d
Compare
rjl493456442
force-pushed
the
block-creation
branch
from
April 17, 2026 01:26
3d88e9d to
67fb3e3
Compare
rjl493456442
force-pushed
the
block-creation
branch
from
April 17, 2026 01:28
67fb3e3 to
afaa572
Compare
jwasinger
reviewed
Apr 19, 2026
jwasinger
left a comment
jwasinger
left a comment
Contributor
There was a problem hiding this comment.
mostly LGTM. Should we preserve the telemetry calls for the miner path?
Member
Author
The engine.Finalize will still be called. I guess open-telemetry hooks will be invoked there. |
Member
|
ah but now we don't measure the state root calculation anymore, right? |
Member
Author
Good catch, i guess we need to following PR to fix the opentelemetry tracing |
gballet
approved these changes
Apr 21, 2026
4 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
FinalizeAndAssemblefrom the consensus engine interfaceand relocates block assembly logic outside of the consensus engine.
Block assembly is consensus-agnostic. Most validations can be performed
by the caller. For example:
The only notable consensus-specific validation is related to uncles. In clique,
the concept of uncles does not exist, and any block containing uncles should
be considered invalid.
Within the block production package, the policy is to produce blocks according
to the latest chain specification. As a result, Clique-specific block production
is no longer supported. This tradeoff is considered acceptable.