accounts/abi/bind: re-export event signature mismatch errors - #34868
Merged
MariusVanDerWijden merged 2 commits intoMay 5, 2026
Merged
Conversation
…Signature Expose the event-unpacking sentinel errors from bind/v2 through the top-level bind package so callers can use errors.Is without importing the v2 sub-package directly. Fixes ethereum#34075
tenderdeve
marked this pull request as ready for review
May 5, 2026 09:10
MariusVanDerWijden
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bind/v2 package already defines ErrEventSignatureMismatch and ErrNoEventSignature, and generated code references them correctly. However, callers importing the top-level bind package have no way to use errors.Is without also importing bind/v2 directly. This re-exports both sentinels through the compatibility shim in bind/old.go, following the same pattern used for ErrNoCode and friends.
Fixes #34075