rpc: add --rpc.http-body-limit flag for HTTP request body size - #35224
Merged
Conversation
Member
|
I think I remember that when we introduced it we hardcoded it deliberately since there wasn't really any use case for bigger http requests. Since that changed, we should just do this |
skylenet
requested review from
MariusVanDerWijden,
gballet,
jwasinger,
lightclient and
rjl493456442
as code owners
June 26, 2026 10:15
The HTTP JSON-RPC server caps request bodies at a hardcoded 5 MB (defaultBodyLimit), with no way to raise it. EEST bloatnet depth benchmarks post worst-case batch requests larger than that during fill-stateful, which the server rejects with 413 Request Entity Too Large. Add a node.Config.HTTPBodyLimit (default 5 MB), wired to the HTTP/WS server config, and expose it via --rpc.http-body-limit (value in megabytes, default 5). Default behaviour is unchanged.
skylenet
force-pushed
the
http-body-limit-flag
branch
from
June 26, 2026 10:16
9915376 to
2a5d898
Compare
MariusVanDerWijden
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP JSON-RPC server caps request bodies at a hardcoded 5 MB (
defaultBodyLimit), with no way to raise it. EEST bloatnet depth benchmarks post worst-case batch requests larger than that during fill-stateful, which the server rejects with413 Request Entity Too Large.This adds
node.Config.HTTPBodyLimit(default 5 MB), wired through to the HTTP/WS server config, and exposes it via--rpc.http-body-limit(value in megabytes, default 5). Default behaviour is unchanged.