This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Fix invalid >2GB relative jumps to shared global functions.#25
Merged
Conversation
If the code pages for the shared global functions happen to be allocated more than 2GB away from other generated code, malformed jumps will be emitted, and crashes ensue. This fixes the issue by turning the global functions into macros. They were all quite small, so this should have minimal impact on code size.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Contributor
|
Thanks @luketwitter ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the code pages for the shared global functions happen to be allocated more than 2GB away
from other generated code, malformed jumps will be emitted, and crashes ensue.
This fixes the issue by turning the global functions into macros. They were all quite small,
so this should have minimal impact on code size.