Include the program counter in contract-reverted messages - #1593
Conversation
| Outcome::Revert => Err(ActorError::unchecked_with_data( | ||
| EVM_CONTRACT_REVERTED, | ||
| "contract reverted".to_string(), | ||
| format!("contract reverted at {0}", output.pc), |
There was a problem hiding this comment.
We could consider adding additional information here. E.g., self destructed v. reverted? Or maybe the ID/address of the actor?
|
Note: this is a consensus critical change solely because it touches the actors. The message altered here is for debugging only and isn't available on-chain (it only shows up in the "backtrace"). |
This makes it possible to tell on which instruction the contract reverted where as previously the message wasn't all that useful. The runtime cost should be negligible.
a896eae to
bbe431a
Compare
|
(but I'll write a mini-FIP if desired) |
|
This is really only consensus-critical in a similar way that rebuilding the actors bundle ends up being consensus critical though, right? It's "breaking" if a downstream consumer is consuming this message and decoding it. But is the |
|
Exactly. The FVM does expose the error message that we're altering here, but via the backtrace (for debugging) not via anything on-chain. |
|
Yeah, given that this is for debugging only, I'm going to say merge it for now. |
2 participants
This makes it possible to tell on which instruction the contract reverted where as previously the message wasn't all that useful. The runtime cost should be negligible.