Skip to content

fix(api): trace transaction api to return correct error - #13614

Merged
rvagg merged 2 commits into
filecoin-project:masterfrom
akaladarshi:akaladarshi/fix-trace-bug
May 18, 2026
Merged

fix(api): trace transaction api to return correct error#13614
rvagg merged 2 commits into
filecoin-project:masterfrom
akaladarshi:akaladarshi/fix-trace-bug

Conversation

@akaladarshi

Copy link
Copy Markdown
Contributor

Related Issues

#13613

Proposed Changes

The PR changes now returns true only if the actor is Either EVM or EAM:

  • With this now the trace call returns correct error code in the trace.

Checklist

Before you mark the PR ready for review, please make sure that:

Trace transaction on hash 0x7285d2336d2c8b351afa17711d910050dc19ff2c0839d07ea85ae17b44721b4c, now correctly returns error Reverted.

Contract:

contract AlwaysRevert {                                                                                                                                                                                                                             
      constructor() {                                                                                                                                                                                                                                 
          revert("nope");                                                                                                                                                                                                                             
      }           
  }

     {
         "id": 1,
         "jsonrpc": "2.0",
         "result": [
             {
                 "type": "create",
                 "error": "Reverted",
                 "subtraces": 0,
                 "traceAddress": [],
                 "action": {
                     "from": "0xb7aa1e9c847cda5f60f1ae6f65c3eae44848d41f",
                     "gas": "0x5e97ed5",
                     "value": "0x0",
                     "init": "0x6080604052348015600e575f5ffd5b5060405162461bcd60e51b8152600401603f906020808252600490820152636e6f706560e01b604082015260600190565b60405180910390fdfe"
                 },
                 "result": {
                     "gasUsed": "0x1b5acd",
                     "code": "0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000046e6f706500000000000000000000000000000000000000000000000000000000"
                 },
                 "blockHash": "0x46f03eaba68948d6198720c6d0d9fe72830f5f8a53716472fee6a55e564f3b3a",
                 "blockNumber": 3693736,
                 "transactionHash": "0x7285d2336d2c8b351afa17711d910050dc19ff2c0839d07ea85ae17b44721b4c",
                 "transactionPosition": 1
             }
         ]
     }

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz May 7, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ⌨️ In Progress in FilOz May 7, 2026
@akaladarshi akaladarshi changed the title fix :traceEVMOrEAM check to return correct value fix(api) :traceEVMOrEAM check to return correct value May 7, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akaladarshi akaladarshi changed the title fix(api) :traceEVMOrEAM check to return correct value fix(api): trace transaction api to return correct error May 7, 2026
@github-actions
github-actions Bot dismissed their stale review May 7, 2026 07:50

PR title now matches the required format.

@akaladarshi
akaladarshi requested a review from rvagg May 15, 2026 11:27
@rvagg
rvagg merged commit 797feeb into filecoin-project:master May 18, 2026
96 checks passed
@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to 🎉 Done in FilOz May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants